diff options
| author | Denys Vlasenko | 2022-05-01 16:37:39 +0200 |
|---|---|---|
| committer | Denys Vlasenko | 2022-05-01 16:37:39 +0200 |
| commit | b5624be6df95fd26d19051af5d02001bbe8f2dd8 (patch) | |
| tree | 8a43835c6a9a7bf2f98e97a652d180f3b406e380 /util-linux | |
| parent | 74716580380d609165cc0be1ae37ee52d77243b2 (diff) | |
| download | busybox-b5624be6df95fd26d19051af5d02001bbe8f2dd8.zip busybox-b5624be6df95fd26d19051af5d02001bbe8f2dd8.tar.gz | |
seedrng: reduce MAX_SEED_LEN from 512 to 256
As proposed by Jason.
getrandom() is more likely to block on reads larger than this.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'util-linux')
| -rw-r--r-- | util-linux/seedrng.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/util-linux/seedrng.c b/util-linux/seedrng.c index 2965f3d..04e52a9 100644 --- a/util-linux/seedrng.c +++ b/util-linux/seedrng.c @@ -56,7 +56,11 @@ enum { MIN_SEED_LEN = SHA256_OUTSIZE, - MAX_SEED_LEN = 512 + /* kernels < 5.18 could return short reads from getrandom() + * if signal is pending and length is > 256. + * Let's limit our reads to 256 bytes. + */ + MAX_SEED_LEN = 256, }; static size_t determine_optimal_seed_len(void) |