summaryrefslogtreecommitdiff
path: root/shell
diff options
context:
space:
mode:
authorIngo van Lil2018-01-05 15:04:23 +0100
committerDenys Vlasenko2018-01-07 14:22:38 +0100
commit9c8e94bc0a3836dd6b8acbcf1fa88283a0a3c148 (patch)
tree9f07ea59974e3863edef50f1a01047de729b2e3d /shell
parent6f4a785bd1bd0e6973b5c27b34b86655b1d7a602 (diff)
downloadbusybox-9c8e94bc0a3836dd6b8acbcf1fa88283a0a3c148.zip
busybox-9c8e94bc0a3836dd6b8acbcf1fa88283a0a3c148.tar.gz
ash: fail if 'shift' operand is out of range
If the numeric argument passed to ash's 'shift' built-in is greater than '$#' the command performs no operation and exits successfully. It should return a non-zero exit code instead: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#shift This is consistent with bash and hush. function old new delta shiftcmd 122 120 -2 Signed-off-by: Ingo van Lil <inguin@gmx.de> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'shell')
-rw-r--r--shell/ash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/shell/ash.c b/shell/ash.c
index dfb7d4d..b73a799 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -10858,7 +10858,7 @@ shiftcmd(int argc UNUSED_PARAM, char **argv)
if (argv[1])
n = number(argv[1]);
if (n > shellparam.nparam)
- n = 0; /* bash compat, was = shellparam.nparam; */
+ return 1;
INT_OFF;
shellparam.nparam -= n;
for (ap1 = shellparam.p; --n >= 0; ap1++) {