summaryrefslogtreecommitdiff
path: root/shell/hush_test
diff options
context:
space:
mode:
authorDenys Vlasenko2021-09-07 01:54:23 +0200
committerDenys Vlasenko2021-09-07 02:01:03 +0200
commitf415e21a7dce1d4f4b760fddfaba85c551681e11 (patch)
tree1c126cfd0ff6193b151db4fddaf79fac3d822dfd /shell/hush_test
parent41beb53787ec798a27f336c4758cb5ebd8f0c75a (diff)
downloadbusybox-f415e21a7dce1d4f4b760fddfaba85c551681e11.zip
busybox-f415e21a7dce1d4f4b760fddfaba85c551681e11.tar.gz
ash: eval: Do not cache value of eflag in evaltree
Upsteam commit: Date: Mon, 17 May 2021 15:19:23 +0800 eval: Do not cache value of eflag in evaltree Patrick BrĂ¼nn <P.Bruenn@beckhoff.com> wrote: > Since we are migrating to Debian bullseye, we discovered a new behavior > with our scripts, which look like this: >>cleanup() { >> set +e >> rmdir "" >>} >>set -eu >>trap 'cleanup' EXIT INT TERM >>echo 'Hello world!' > > With old dash v0.5.10.2 this script would return 0 as we expected it. > But since commit 62cf6955f8abe875752d7163f6f3adbc7e49ebae it returns > the last exit code of our cleanup function. ... Thanks for the report. This is actually a fairly old bug with set -e that's just been exposed by the exit status change. What's really happening is that cleanup itself is triggering a set -e exit incorrectly because evaltree cached the value of eflag prior to the function call. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'shell/hush_test')
0 files changed, 0 insertions, 0 deletions