diff options
author | Sören Tempel | 2022-02-28 08:36:50 +0100 |
---|---|---|
committer | Denys Vlasenko | 2022-03-01 08:47:43 +0100 |
commit | fa52ac9781f479de8ab4d8526276244c0a0471f4 (patch) | |
tree | a1cf6cad888fa4e22dd160b334e53854562cba47 /shell/ash_test/ash-vars/var_10.right | |
parent | 1891fdda59092a215d3a407d9108bbbe6ab8df7a (diff) | |
download | busybox-fa52ac9781f479de8ab4d8526276244c0a0471f4.zip busybox-fa52ac9781f479de8ab4d8526276244c0a0471f4.tar.gz |
ash: don't read past end of var in subvareval for bash substitutions
Without this patch, BusyBox handles bash pattern substitutions without
a terminating '/' character incorrectly.
Consider the following shell script:
_bootstrapver=5.0.211-r0
_referencesdir="/usr/${_bootstrapver/-*}/Sources"
echo $_referencesdir
This should output `/usr/5.0.211/Sources`. However, without this patch
it instead outputs `/usr/5.0.211Sources`. This is due to the fact that
BusyBox expects the bash pattern substitutions to always be terminated
with a '/' (at least in this part of subvareval) and thus reads passed
the substitution itself and consumes the '/' character which is part of
the literal string. If there is no '/' after the substitution then
BusyBox might perform an out-of-bounds read under certain circumstances.
When replacing the bash pattern substitution with `${_bootstrapver/-*/}`,
or with this patch applied, ash outputs the correct value.
Signed-off-by: Sören Tempel <soeren@soeren-tempel.net>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'shell/ash_test/ash-vars/var_10.right')
0 files changed, 0 insertions, 0 deletions