summaryrefslogtreecommitdiff
path: root/libbb
diff options
context:
space:
mode:
authorDenys Vlasenko2010-10-19 23:07:49 +0200
committerDenys Vlasenko2010-10-19 23:07:49 +0200
commit0016bcee374606e79c48a1a97479b0521f947942 (patch)
treecad91be9d3821dfb26f433b19ca0fb24d9c1ba8a /libbb
parentef6c6d8cfef071435ccf275ad404a501626b706c (diff)
downloadbusybox-0016bcee374606e79c48a1a97479b0521f947942.zip
busybox-0016bcee374606e79c48a1a97479b0521f947942.tar.gz
klogd: do not log partial lines
function old new delta overlapping_strcpy 15 18 +3 klogd_main 438 436 -2 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'libbb')
-rw-r--r--libbb/safe_strncpy.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/libbb/safe_strncpy.c b/libbb/safe_strncpy.c
index 8eb6a01..5eb0db0 100644
--- a/libbb/safe_strncpy.c
+++ b/libbb/safe_strncpy.c
@@ -20,8 +20,13 @@ char* FAST_FUNC safe_strncpy(char *dst, const char *src, size_t size)
/* Like strcpy but can copy overlapping strings. */
void FAST_FUNC overlapping_strcpy(char *dst, const char *src)
{
- while ((*dst = *src) != '\0') {
- dst++;
- src++;
+ /* Cheap optimization for dst == src case -
+ * better to have it here than in many callers.
+ */
+ if (dst != src) {
+ while ((*dst = *src) != '\0') {
+ dst++;
+ src++;
+ }
}
}