diff options
| author | Lev Stipakov | 2023-09-22 12:50:55 +0200 |
|---|---|---|
| committer | Gert Doering | 2023-09-22 14:01:46 +0200 |
| commit | df624fb6d63db6b2a3b0c40597cee74c61b8ab2c (patch) | |
| tree | ff6cccf21cd44ff4fb30e997ee30a3d3a0da61b7 /src | |
| parent | 95cc5faa16833acaf12a4d273c5c848984fc73ce (diff) | |
| download | openvpn-df624fb6d63db6b2a3b0c40597cee74c61b8ab2c.zip openvpn-df624fb6d63db6b2a3b0c40597cee74c61b8ab2c.tar.gz | |
Warn user if INFO control command is too long
"INFO_PRE,..." command length is limited to 256 bytes. If the server
implementation pushes command which is too long, warn the user and
don't send the truncated command to a management client.
Change-Id: If3c27a2a2ba24f2af0e3e3c95eea57ed420b2542
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20230922105055.37969-1-frank@lichtenheld.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27062.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'src')
| -rw-r--r-- | src/openvpn/push.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/openvpn/push.c b/src/openvpn/push.c index 5f5755a..2249434 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -242,8 +242,14 @@ server_pushed_info(struct context *c, const struct buffer *buffer, * for management greeting and we don't want to confuse the client */ struct buffer out = alloc_buf_gc(256, &gc); - buf_printf(&out, ">%s:%s", "INFOMSG", m); - management_notify_generic(management, BSTR(&out)); + if (buf_printf(&out, ">%s:%s", "INFOMSG", m)) + { + management_notify_generic(management, BSTR(&out)); + } + else + { + msg(D_PUSH_ERRORS, "WARNING: Received INFO command is too long, won't notify management client."); + } gc_free(&gc); } |