diff options
| author | Frank Lichtenheld | 2024-01-19 13:03:41 +0100 |
|---|---|---|
| committer | Gert Doering | 2024-01-19 14:09:47 +0100 |
| commit | 68b00a54e779325f4ac9d9416b4e85261f771c23 (patch) | |
| tree | 2a456313b4b18f59ff7ee8b181582af1a08ba462 /src/openvpn | |
| parent | 7b1f2009ce9670e2e0ffea0c01b1c4922a2d4369 (diff) | |
| download | openvpn-68b00a54e779325f4ac9d9416b4e85261f771c23.zip openvpn-68b00a54e779325f4ac9d9416b4e85261f771c23.tar.gz | |
buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0'
As Coverity says:
An unsigned value can never be negative, so this test will always
evaluate the same way.
Was changed from int to size_t in commit
7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning,
but the check did not make sense before, either.
Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240119120341.22933-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28093.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit bc29bd6a3376158b73d069758122739fbf93c022)
Diffstat (limited to 'src/openvpn')
| -rw-r--r-- | src/openvpn/buffer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c index 24f1ef2..0a63512 100644 --- a/src/openvpn/buffer.c +++ b/src/openvpn/buffer.c @@ -822,7 +822,7 @@ bool buf_string_match_head_str(const struct buffer *src, const char *match) { const size_t size = strlen(match); - if (size < 0 || size > src->len) + if (size > src->len) { return false; } |