From 68b00a54e779325f4ac9d9416b4e85261f771c23 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Fri, 19 Jan 2024 13:03:41 +0100 Subject: buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0' As Coverity says: An unsigned value can never be negative, so this test will always evaluate the same way. Was changed from int to size_t in commit 7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning, but the check did not make sense before, either. Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240119120341.22933-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28093.html Signed-off-by: Gert Doering (cherry picked from commit bc29bd6a3376158b73d069758122739fbf93c022) --- src/openvpn/buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/openvpn') diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c index 24f1ef2..0a63512 100644 --- a/src/openvpn/buffer.c +++ b/src/openvpn/buffer.c @@ -822,7 +822,7 @@ bool buf_string_match_head_str(const struct buffer *src, const char *match) { const size_t size = strlen(match); - if (size < 0 || size > src->len) + if (size > src->len) { return false; } -- cgit v1.1