diff options
| author | Arne Schwabe | 2022-12-15 20:01:40 +0100 |
|---|---|---|
| committer | Gert Doering | 2022-12-16 18:10:18 +0100 |
| commit | f2454ec6363d5578875d020179b38074b3c10964 (patch) | |
| tree | a7a6493892fcf0fceba62321241e860716b6a95b /src/openvpn/init.c | |
| parent | 4b6854881c36e16054878e0467ef87d925e20cae (diff) | |
| download | openvpn-f2454ec6363d5578875d020179b38074b3c10964.zip openvpn-f2454ec6363d5578875d020179b38074b3c10964.tar.gz | |
Eliminate or comment empty blocks and switch fallthrough
These empty blocks are intentional but trigger code checkers and
were pointed out by Trail of Bits in the security audits. Add comments
to them or eliminate them whatever makes more sense.
For fallthrough C23 [1] has a standard way to signal that but we not
adding a C23 feature to our codebase, so use a comment for now.
[1] https://en.cppreference.com/w/c/language/attributes/fallthrough
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20221215190143.2107896-6-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25735.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'src/openvpn/init.c')
| -rw-r--r-- | src/openvpn/init.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 74b3803..219bff8 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -2921,6 +2921,7 @@ do_init_crypto_tls_c1(struct context *c) case AR_INTERACT: ssl_purge_auth(false); + /* Intentional [[fallthrough]]; */ case AR_NOINTERACT: c->sig->signal_received = SIGUSR1; /* SOFT-SIGUSR1 -- Password failure error */ |