diff options
| author | Arne Schwabe | 2022-10-16 17:49:53 +0200 |
|---|---|---|
| committer | Gert Doering | 2022-10-17 10:24:42 +0200 |
| commit | d468dff7bdfd79059818c190ddf41b125bb658de (patch) | |
| tree | 60d1d9c189bf696730fb9e2780b793d37124aea2 /Changes.rst | |
| parent | 6bbd89c5c82e7a2366ecac969b35f88797a73763 (diff) | |
| download | openvpn-d468dff7bdfd79059818c190ddf41b125bb658de.zip openvpn-d468dff7bdfd79059818c190ddf41b125bb658de.tar.gz | |
Change exit signal in P2P to be a SIGUSR1 and delayed CC exit in P2MP
From the implemention of explicit-notify and the fact that it is a an
OCC message (basically the rudimentary predecessor to control channel),
this message is very old.
I think in the past this feature fit nicely to the weird inetd + openvpn
mode that seems to have far to many hacks still left in our code. With
inetd, it made sense that the server instance quits if you press C-c
on the client.
In our current state where inetd is no longer supported, this behaviour
to exit makes little sense and this patch changes the behaviour to SIGUSR1.
Testing this lead to a confused v2 of the patch and also finally the
insight that if a CC channel exit is triggered too early the remaining
control channel packets coming in after that can trigger the HMAC code
to open a sessions again if the whole session lasted less than two
minutes (with default settings).
Patch v2: use different signals for p2mp and p2p
Patch v3: use delayed exit for P2MP/CC exit and USR1 for everything else
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20221016154953.2483509-1-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25403.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'Changes.rst')
| -rw-r--r-- | Changes.rst | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/Changes.rst b/Changes.rst index df56f76..dfe5bf0 100644 --- a/Changes.rst +++ b/Changes.rst @@ -163,6 +163,13 @@ User-visible Changes - :code:`link_mtu` parameter is removed from environment or replaced with 0 when scripts are called with parameters. This parameter is unreliable and no longer internally calculated. +- In point-to-point OpenVPN setups (no ``--server``), using + ``--explict-exit-notiy`` on one end would terminate the other side at + session end. This is considered a no longer useful default and has + been changed to "restart on reception of explicit-exit-notify message". + If the old behaviour is still desired, ``--remap-usr1 SIGTERM`` can be used. + + Overview of changes in 2.5 ========================== |