aboutsummaryrefslogtreecommitdiff
path: root/Changes.rst
diff options
context:
space:
mode:
authorSteffan Karger2017-05-09 21:30:08 +0200
committerDavid Sommerseth2017-05-11 00:35:53 +0200
commit5774cf4c25e1d8bf4e544702db8f157f111c9d93 (patch)
tree0cc921e7876b5e58824c348c2f22ddd3351a0b06 /Changes.rst
parent5806f66eb927a6a698c0f067f563d7bc2203a376 (diff)
downloadopenvpn-5774cf4c25e1d8bf4e544702db8f157f111c9d93.zip
openvpn-5774cf4c25e1d8bf4e544702db8f157f111c9d93.tar.gz
Don't assert out on receiving too-large control packets (CVE-2017-7478)
Commit 3c1b19e0 changed the maximum size of accepted control channel packets. This was needed for crypto negotiation (which is needed for a nice transition to a new default cipher), but exposed a DoS vulnerability. The vulnerability was found during the OpenVPN 2.4 code audit by Quarkslab (commisioned by OSTIF). To fix the issue, we should not ASSERT() on external input (in this case the received packet size), but instead gracefully error out and drop the invalid packet. CVE: 2017-7478 Signed-off-by: Steffan Karger <steffan.karger@fox-it.com> Acked-by: David Sommerseth <davids@openvpn.net> Message-Id: <1494358209-4568-2-git-send-email-steffan.karger@fox-it.com> URL: http://www.mail-archive.com/search?l=mid&q=1494358209-4568-2-git-send-email-steffan.karger@fox-it.com Signed-off-by: David Sommerseth <davids@openvpn.net>
Diffstat (limited to 'Changes.rst')
-rw-r--r--Changes.rst8
1 files changed, 8 insertions, 0 deletions
diff --git a/Changes.rst b/Changes.rst
index 3dba7e0..734ef73 100644
--- a/Changes.rst
+++ b/Changes.rst
@@ -327,3 +327,11 @@ Bugfixes
--------
- Fix memory leak introduced in 2.4.1: if --remote-cert-tls is used, we leaked
some memory on each TLS (re)negotiation.
+
+Security
+--------
+- Fix a pre-authentication denial-of-service attack on both clients and servers.
+ By sending a too-large control packet, OpenVPN 2.4.0 or 2.4.1 can be forced
+ to hit an ASSERT() and stop the process. If ``--tls-auth`` or ``--tls-crypt``
+ is used, only attackers that have the ``--tls-auth`` or ``--tls-crypt`` key
+ can mount an attack. (OSTIF/Quarkslab audit finding 5.1, CVE-2017-7478)