aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrank Lichtenheld2024-01-29 15:57:56 +0100
committerGert Doering2024-01-29 16:03:42 +0100
commite1f8c599aeb840909f5ea8e9ae0bc4dab5bc7deb (patch)
treea7a62fe7a0df4ce8fb273106c8edcdb643517d7f
parent55418bf62eaff1c4323d206181cd8a5f88e7c6c7 (diff)
downloadopenvpn-e1f8c599aeb840909f5ea8e9ae0bc4dab5bc7deb.zip
openvpn-e1f8c599aeb840909f5ea8e9ae0bc4dab5bc7deb.tar.gz
gerrit-send-mail: Make output consistent across systems
When writing the file specify encoding and newline, so that the local settings (like locale) do not change the output. Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org> Message-Id: <20240129145756.769-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28153.html Signed-off-by: Gert Doering <gert@greenie.muc.de>
-rwxr-xr-xdev-tools/gerrit-send-mail.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py
index 5429aef..67a2cf1 100755
--- a/dev-tools/gerrit-send-mail.py
+++ b/dev-tools/gerrit-send-mail.py
@@ -109,7 +109,7 @@ Acked-by according to Gerrit (reflected above):
)
filename = f"gerrit-{args.changeid}-{details['revision']}.patch"
patch_text_final = patch_text_mod.replace("Subject: [PATCH]", f"Subject: [PATCH v{details['revision']}]")
- with open(filename, "w") as patch_file:
+ with open(filename, "w", encoding="utf-8", newline="\n") as patch_file:
patch_file.write(patch_text_final)
print("send with:")
print(f"git send-email --in-reply-to {details['msg_id']} {filename}")