From 802a7be54ffcf6e45808d72e2562456bba564028 Mon Sep 17 00:00:00 2001
From: Denis Vlasenko
Date: Sun, 19 Oct 2008 19:54:49 +0000
Subject: add comment explaining previous change

---
 util-linux/volume_id/get_devname.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

(limited to 'util-linux/volume_id')

diff --git a/util-linux/volume_id/get_devname.c b/util-linux/volume_id/get_devname.c
index e99c15b..d82808f 100644
--- a/util-linux/volume_id/get_devname.c
+++ b/util-linux/volume_id/get_devname.c
@@ -107,6 +107,17 @@ uuidcache_init(void)
 	if (uuidCache)
 		return;
 
+	/* We were scanning /proc/partitions
+	 * and /proc/sys/dev/cdrom/info here.
+	 * Missed volume managers. I see that "standard" blkid uses these:
+	 * /dev/mapper/control
+	 * /proc/devices
+	 * /proc/evms/volumes
+	 * /proc/lvm/VGs
+	 * This is unacceptably complex. Let's just scan /dev.
+	 * (Maybe add scanning of /sys/block/XXX/dev for devices
+	 * somehow not having their /dev/XXX entries created?) */
+
 	recursive_action("/dev", ACTION_RECURSE,
 		uuidcache_check_device, /* file_action */
 		NULL, /* dir_action */
-- 
cgit v1.1