From 92657d484f4f95ce4579ad095c9caf596a737e5b Mon Sep 17 00:00:00 2001
From: Denis Vlasenko
Date: Tue, 19 Feb 2008 01:10:20 +0000
Subject: syslogd: tighten up hostname handling.

---
 sysklogd/syslogd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'sysklogd')

diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c
index dc5e625..bed1816 100644
--- a/sysklogd/syslogd.c
+++ b/sysklogd/syslogd.c
@@ -649,10 +649,10 @@ int syslogd_main(int argc, char **argv)
 
 	/* Store away localhost's name before the fork */
 	gethostname(G.localHostName, sizeof(G.localHostName));
-	p = strchr(G.localHostName, '.');
-	if (p) {
-		*p = '\0';
-	}
+	/* "It is unspecified whether the truncated hostname
+	 * will be null-terminated". Idiots! */
+	G.localHostName[sizeof(G.localHostName) - 1] = '\0';
+	*strchrnul(G.localHostName, '.') = '\0';
 
 	if (!(option_mask32 & OPT_nofork)) {
 		bb_daemonize_or_rexec(DAEMON_CHDIR_ROOT, argv);
-- 
cgit v1.1