From bab8828b0dad1d51d6b34e38249f0641ca64b1e9 Mon Sep 17 00:00:00 2001
From: Denys Vlasenko
Date: Mon, 12 Jun 2023 16:37:19 +0200
Subject: hush: fix expansion of space in "a=${a:+$a }c" construct

function                                             old     new   delta
encode_then_append_var_plusminus                     554     552      -2

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
---
 shell/ash_test/ash-quoting/space_in_varexp1.right   | 2 ++
 shell/ash_test/ash-quoting/space_in_varexp1.tests   | 6 ++++++
 shell/hush.c                                        | 2 +-
 shell/hush_test/hush-quoting/space_in_varexp1.right | 2 ++
 shell/hush_test/hush-quoting/space_in_varexp1.tests | 6 ++++++
 5 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 shell/ash_test/ash-quoting/space_in_varexp1.right
 create mode 100755 shell/ash_test/ash-quoting/space_in_varexp1.tests
 create mode 100644 shell/hush_test/hush-quoting/space_in_varexp1.right
 create mode 100755 shell/hush_test/hush-quoting/space_in_varexp1.tests

(limited to 'shell')

diff --git a/shell/ash_test/ash-quoting/space_in_varexp1.right b/shell/ash_test/ash-quoting/space_in_varexp1.right
new file mode 100644
index 0000000..a617a91
--- /dev/null
+++ b/shell/ash_test/ash-quoting/space_in_varexp1.right
@@ -0,0 +1,2 @@
+1:'b c'
+2:'b c'
diff --git a/shell/ash_test/ash-quoting/space_in_varexp1.tests b/shell/ash_test/ash-quoting/space_in_varexp1.tests
new file mode 100755
index 0000000..1589587
--- /dev/null
+++ b/shell/ash_test/ash-quoting/space_in_varexp1.tests
@@ -0,0 +1,6 @@
+a=b
+a=${a:+$a }c
+echo "1:'$a'"
+a=b
+a="${a:+$a }c"
+echo "2:'$a'"
diff --git a/shell/hush.c b/shell/hush.c
index cdaa67a..dbc4aec 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -6398,7 +6398,7 @@ static NOINLINE int encode_then_append_var_plusminus(o_string *output, int n,
 		if (!dest.o_expflags) {
 			if (ch == EOF)
 				break;
-			if (!dquoted && strchr(G.ifs, ch)) {
+			if (!dquoted && !(output->o_expflags & EXP_FLAG_SINGLEWORD) && strchr(G.ifs, ch)) {
 				/* PREFIX${x:d${e}f ...} and we met space: expand "d${e}f" and start new word.
 				 * do not assume we are at the start of the word (PREFIX above).
 				 */
diff --git a/shell/hush_test/hush-quoting/space_in_varexp1.right b/shell/hush_test/hush-quoting/space_in_varexp1.right
new file mode 100644
index 0000000..a617a91
--- /dev/null
+++ b/shell/hush_test/hush-quoting/space_in_varexp1.right
@@ -0,0 +1,2 @@
+1:'b c'
+2:'b c'
diff --git a/shell/hush_test/hush-quoting/space_in_varexp1.tests b/shell/hush_test/hush-quoting/space_in_varexp1.tests
new file mode 100755
index 0000000..1589587
--- /dev/null
+++ b/shell/hush_test/hush-quoting/space_in_varexp1.tests
@@ -0,0 +1,6 @@
+a=b
+a=${a:+$a }c
+echo "1:'$a'"
+a=b
+a="${a:+$a }c"
+echo "2:'$a'"
-- 
cgit v1.1