From 8025afad8af99c770d8be3aeca0dbe6329e64d61 Mon Sep 17 00:00:00 2001
From: Bernhard Reutner-Fischer
Date: Mon, 2 Apr 2007 16:54:41 +0000
Subject: - use xregcomp. Untested. vda, isn't there a regfree missing here?
text data bss dec hex filename 2522 0 0 2522
9da expr.o.r18305 2478 0 0 2478 9ae expr.o
---
coreutils/expr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
(limited to 'coreutils')
diff --git a/coreutils/expr.c b/coreutils/expr.c
index 8eda367..8401594 100644
--- a/coreutils/expr.c
+++ b/coreutils/expr.c
@@ -226,8 +226,7 @@ of a basic regular expression is not portable; it is being ignored", pv->u.s);
memset(&re_buffer, 0, sizeof(re_buffer));
memset(re_regs, 0, sizeof(*re_regs));
- if (regcomp(&re_buffer, pv->u.s, 0) != 0)
- bb_error_msg_and_die("invalid regular expression");
+ xregcomp(&re_buffer, pv->u.s, 0);
/* expr uses an anchored pattern match, so check that there was a
* match and that the match starts at offset 0. */
@@ -246,6 +245,7 @@ of a basic regular expression is not portable; it is being ignored", pv->u.s);
else
v = int_value(0);
}
+//FIXME: sounds like here is a bit missing: regfree(&re_buffer);
return v;
}
--
cgit v1.1