From 0f296a3a56b52842057e5a2bc653621a3a6c7bec Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 14 Oct 2015 13:21:01 +0200 Subject: libiproute: rename invarg(a,b) to invarg_1_to_2(a,b) invarg(a,b) - "invalid argument", but how a and b enter the message? invarg_1_to_2(a,b) is somewhat easier to read: "invalid argument 'a' to 'b'" Audit of usage revealed a number of bad uses, with too long messages. text data bss dec hex filename 938848 932 17448 957228 e9b2c busybox_old 938788 932 17448 957168 e9af0 busybox_unstripped Signed-off-by: Denys Vlasenko --- coreutils/dd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'coreutils') diff --git a/coreutils/dd.c b/coreutils/dd.c index 53a843c..6a5288d 100644 --- a/coreutils/dd.c +++ b/coreutils/dd.c @@ -326,7 +326,7 @@ int dd_main(int argc UNUSED_PARAM, char **argv) *arg = '\0'; n = index_in_strings(conv_words, val); if (n < 0) - bb_error_msg_and_die(bb_msg_invalid_arg, val, "conv"); + bb_error_msg_and_die(bb_msg_invalid_arg_to, val, "conv"); G.flags |= (1 << n); if (!arg) /* no ',' left, so this was the last specifier */ break; @@ -368,7 +368,7 @@ int dd_main(int argc UNUSED_PARAM, char **argv) int n; n = index_in_strings(status_words, val); if (n < 0) - bb_error_msg_and_die(bb_msg_invalid_arg, val, "status"); + bb_error_msg_and_die(bb_msg_invalid_arg_to, val, "status"); G.flags |= FLAG_STATUS << n; /*continue;*/ } -- cgit v1.1