From ecb29573e9d2caf59de17fcb4efff129b35ad792 Mon Sep 17 00:00:00 2001 From: Rob Landley Date: Tue, 22 Aug 2006 23:40:28 +0000 Subject: "Jordan Crouse" says: The following patch makes coreutils/test.c act fail gracefully if getgroups() returns a -1.  This fixes a problem on the One Laptop Per Child ROM image whereby we were getting odd Memory exhausted messages for '[' and 'test'. Found by Mitch Bradley (Tweaked by Rob: no need to initialize a static to NULL, or realloc something that's only allocated when it's NULL.) --- coreutils/test.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'coreutils/test.c') diff --git a/coreutils/test.c b/coreutils/test.c index bbc8022..c1097c2 100644 --- a/coreutils/test.c +++ b/coreutils/test.c @@ -151,7 +151,7 @@ typedef int arith_t; static char **t_wp; static struct t_op const *t_wp_op; -static gid_t *group_array = NULL; +static gid_t *group_array; static int ngroups; static enum token t_lex(char *s); @@ -547,8 +547,10 @@ static int test_eaccess(char *path, int mode) static void initialize_group_array(void) { ngroups = getgroups(0, NULL); - group_array = xrealloc(group_array, ngroups * sizeof(gid_t)); - getgroups(ngroups, group_array); + if (ngroups > 0) { + group_array = xmalloc(ngroups * sizeof(gid_t)); + getgroups(ngroups, group_array); + } } /* Return non-zero if GID is one that we have in our groups list. */ -- cgit v1.1