From 990025a7d971bbbdd982d2d070d3e47628d0fac0 Mon Sep 17 00:00:00 2001 From: Rob Landley Date: Thu, 10 Nov 2005 06:26:40 +0000 Subject: Ok, I've converted the contents of the "testing/sed" directory into a sed.tests file. My brain hurts now. (Lots of boggling at sed minutiae and corner cases and going "why is gnu giving that output". The behavior of N and n with regard to EOF are only understandable if you read the Open Group spec, not if you read the sed info page, by the way...) Some of the existing sed tests are just nuts. For example, sed-next-line is testing for our behavior (which is wrong), and would fail if run against gnu sed (which was getting it right. Again, this was a spec-boggling moment, with much head scratching. I've got to add a debug mode where the stuff output by the p command is a different color from the stuff output by normal end of script printing (when not suppressed by -n).) As for sed-handles-unsatisifed-backrefs: what is this test trying to _do_? I ran it against gnu sed and got an error message, and this behavior sounds perfectly reasonable. (It _is_ an unsatisfied backref.) The fact we currently ignore this case (and treat \1 as an empty string) isn't really behavior we should have a test depend on for success. The remaining one is sed-aic-commands, which is long and complicated. I'm trying to figure out if I should chop this into a number of smaller tests, or if having one big "does-many-things" test is a good idea. In any case, the _next_ step is to go through the Open Group standard and make tests for every case not yet covered. (And there are plenty. There are few comments in the file already.) Plus I have notes about corner cases from development that I need to collate and put into here. This file is maybe the first 1/3 of a truly comprehensive sed test. Rob --- testsuite/sed.tests | 109 +++++++++++++++++ testsuite/sed/sed-accepts-blanks-before-command | 1 - testsuite/sed/sed-aic-commands | 134 --------------------- .../sed/sed-append-hold-space-to-pattern-space | 13 -- testsuite/sed/sed-append-next-line | 19 --- testsuite/sed/sed-branch | 1 - testsuite/sed/sed-branch-conditional | 15 --- testsuite/sed/sed-branch-conditional-inverted | 14 --- testsuite/sed/sed-branch-conditional2 | 11 -- testsuite/sed/sed-branch-no-label | 1 - testsuite/sed/sed-chains-substs | 1 - testsuite/sed/sed-chains-substs2 | 1 - .../sed/sed-does-not-substitute-in-deleted-line | 2 - testsuite/sed/sed-handles-embedded-slashes | 1 - testsuite/sed/sed-handles-empty-lines | 1 - testsuite/sed/sed-handles-unsatisfied-backrefs | 6 - testsuite/sed/sed-next-line | 12 -- .../sed/sed-prints-line-once-for-multiple-substs | 4 - testsuite/sed/sed-recurses-properly | 1 - testsuite/sed/sed-regex-match-newline | 10 -- .../sed/sed-splits-edit-commands-on-command-line | 9 -- testsuite/sed/sed-subst-subprint | 9 -- testsuite/sed/sed-write-to-stdout | 10 -- 23 files changed, 109 insertions(+), 276 deletions(-) create mode 100755 testsuite/sed.tests delete mode 100644 testsuite/sed/sed-accepts-blanks-before-command delete mode 100644 testsuite/sed/sed-aic-commands delete mode 100644 testsuite/sed/sed-append-hold-space-to-pattern-space delete mode 100644 testsuite/sed/sed-append-next-line delete mode 100644 testsuite/sed/sed-branch delete mode 100644 testsuite/sed/sed-branch-conditional delete mode 100755 testsuite/sed/sed-branch-conditional-inverted delete mode 100644 testsuite/sed/sed-branch-conditional2 delete mode 100644 testsuite/sed/sed-branch-no-label delete mode 100644 testsuite/sed/sed-chains-substs delete mode 100644 testsuite/sed/sed-chains-substs2 delete mode 100644 testsuite/sed/sed-does-not-substitute-in-deleted-line delete mode 100644 testsuite/sed/sed-handles-embedded-slashes delete mode 100644 testsuite/sed/sed-handles-empty-lines delete mode 100644 testsuite/sed/sed-handles-unsatisfied-backrefs delete mode 100644 testsuite/sed/sed-next-line delete mode 100644 testsuite/sed/sed-prints-line-once-for-multiple-substs delete mode 100644 testsuite/sed/sed-recurses-properly delete mode 100644 testsuite/sed/sed-regex-match-newline delete mode 100644 testsuite/sed/sed-splits-edit-commands-on-command-line delete mode 100644 testsuite/sed/sed-subst-subprint delete mode 100644 testsuite/sed/sed-write-to-stdout diff --git a/testsuite/sed.tests b/testsuite/sed.tests new file mode 100755 index 0000000..479dd9a --- /dev/null +++ b/testsuite/sed.tests @@ -0,0 +1,109 @@ +#!/bin/sh + +# SUSv3 compliant sed tests. +# Copyright 2005 by Rob Landley +# Licensed under GPL v2, see file LICENSE for details. + +[ -z "$COMMAND" ] && COMMAND=sed +. testing.sh + +# testing "description" "arguments" "result" "infile" "stdin" + +# Corner cases +testing "sed as cat" '"" -' "hello\n" "" "hello\n" +testing "sed handles empty lines" "-e 's/\$/@/'" "@\n" "" "\n" + +# no files (stdin) +# explicit stdin +# mix files and stdin (various orders) +# list stdin twice +# Trailing EOF. +# Multiple files: first no EOF, second length 0. +# Match $, at end of each file or all files? +# First no EOF, second no matches at all. +# -e corner cases +# without -e +# multiple -e +# interact with a +# -eee arg1 arg2 arg3 +# -f corner cases +# -e -f -e +# -n corner cases +# no newline at EOF? +# -r corner cases +# Just make sure it works. +# -i corner cases: +# sed -i - +# permissions +# -i on a symlink +# on a directory + +# command list +testing "sed accepts blanks before command" "-e '1 d'" "" "" "" +testing "sed accepts newlines in -e" "-e 'i\ +1 +a\ +3'" "1\n2\n3\n" "" "2\n" +testing "sed accepts multiple -e" "-e 'i\' -e '1' -e 'a\' -e '3'" \ + "1\n2\n3\n" "" "2\n" + +# substitutions +testing "sed -n" "-n -e s/foo/bar/ -e s/bar/baz/" "" "" "foo\n" +testing "sed s//p" "-e s/foo/bar/p -e s/bar/baz/p" "bar\nbaz\nbaz\n" \ + "" "foo\n" +testing "sed -n s//p" "-ne s/abc/def/p" "def\n" "" "abc\n" +testing "sed s//g (exhaustive)" "-e 's/[[:space:]]*/,/g'" ",1,2,3,4,5,\n" \ + "" "12345\n" +testing "sed s arbitrary delimiter" "-e 's woo boing '" "boing\n" "" "woo\n" +testing "sed s chains" "-e s/foo/bar/ -e s/bar/baz/" "baz\n" "" "foo\n" +testing "sed s chains2" "-e s/foo/bar/ -e s/baz/nee/" "bar\n" "" "foo\n" +testing "sed s [delimiter]" "-e 's@[@]@@'" "onetwo" "" "one@two" + +# branch +testing "sed b (branch)" "-e 'b one;p;: one'" "foo\n" "" "foo\n" +testing "sed b (branch with no label jumps to end)" "-e 'b;p'" \ + "foo\n" "" "foo\n" + +# test and branch +testing "sed t (test/branch)" "-e 's/a/1/;t one;p;: one;p'" \ + "1\n1\nb\nb\nb\nc\nc\nc\n" "" "a\nb\nc\n" +testing "sed t (test/branch clears test bit)" "-e 's/a/b/;:loop;t loop'" \ + "b\nb\nc\n" "" "a\nb\nc\n" +testing "sed T (!test/branch)" "-e 's/a/1/;T notone;p;: notone;p'" \ + "1\n1\n1\nb\nb\nc\nc\n" "" "a\nb\nc\n" + +# Normal sed end-of-script doesn't print "c" because n flushed the pattern +# space. If n hits EOF, pattern space is empty when script ends. +# Query: how does this interact with no newline at EOF? +testing "sed n (flushes pattern space, terminates early)" "-e 'n;p'" \ + "a\nb\nb\nc\n" "" "a\nb\nc\n" +# N does _not_ flush pattern space, therefore c is still in there @ script end. +testing "sed N (doesn't flush pattern space when terminating)" "-e 'N;p'" \ + "a\nb\na\nb\nc\n" "" "a\nb\nc\n" +testing "sed address match newline" '"/b/N;/b\\nc/i woo"' "a\nwoo\nb\nc\nd\n" \ + "" "a\nb\nc\nd\n" + +# Multiple lines in pattern space +testing "sed N (stops at end of input) and P (prints to first newline only)" \ + "-n 'N;P;p'" "a\na\nb\n" "" "a\nb\nc\n" + +# Hold space +testing "sed G (append hold space to pattern space)" 'G' "a\n\nb\n\nc\n\n" \ + "" "a\nb\nc\n" +#testing "sed g/G (swap/append hold and patter space)" +#testing "sed g (swap hold/pattern space)" + +testing "sed d ends script iteration" \ + "-e '/ook/d;s/ook/ping/p;i woot'" "" "" "ook\n" +testing "sed d ends script iteration (2)" \ + "-e '/ook/d;a\' -e 'bang'" "woot\nbang\n" "" "ook\nwoot\n" + +# Ponder this a bit more, why "woo not found" from gnu version? +#testing "sed doesn't substitute in deleted line" \ +# "-e '/ook/d;s/ook//;t woo;a bang;'" "bang" "" "ook\n" + +# This makes both seds very unhappy. Why? +#testing "sed -g (exhaustive)" "sed -e 's/[[:space:]]*/,/g'" ",1,2,3,4,5," \ +# "" "12345" + +exit $FAILCOUNT diff --git a/testsuite/sed/sed-accepts-blanks-before-command b/testsuite/sed/sed-accepts-blanks-before-command deleted file mode 100644 index 9597c2f..0000000 --- a/testsuite/sed/sed-accepts-blanks-before-command +++ /dev/null @@ -1 +0,0 @@ -busybox sed -e '1 d' input <output <output <output <output <output <output <foo -cmp foo /dev/null diff --git a/testsuite/sed/sed-handles-embedded-slashes b/testsuite/sed/sed-handles-embedded-slashes deleted file mode 100644 index cc28761..0000000 --- a/testsuite/sed/sed-handles-embedded-slashes +++ /dev/null @@ -1 +0,0 @@ -test "$(echo fu/bar | busybox sed -e 's/[/]//')" = fubar diff --git a/testsuite/sed/sed-handles-empty-lines b/testsuite/sed/sed-handles-empty-lines deleted file mode 100644 index 2bb8f04..0000000 --- a/testsuite/sed/sed-handles-empty-lines +++ /dev/null @@ -1 +0,0 @@ -test `echo | busybox sed -e 's/$/@/'` = @ diff --git a/testsuite/sed/sed-handles-unsatisfied-backrefs b/testsuite/sed/sed-handles-unsatisfied-backrefs deleted file mode 100644 index 61bff88..0000000 --- a/testsuite/sed/sed-handles-unsatisfied-backrefs +++ /dev/null @@ -1,6 +0,0 @@ -busybox sed -e 's/.*root=/\1/' >output <output <output <output < output -cmp output - <output <output <