From 37201213ca45f2163abed70a213bb24956b243a8 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 2 Apr 2010 07:04:44 +0200 Subject: ifplugd: more robust interface name match check function old new delta check_existence_through_netlink 278 308 +30 Signed-off-by: Denys Vlasenko --- networking/ifplugd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/networking/ifplugd.c b/networking/ifplugd.c index f398cca..41b04c4 100644 --- a/networking/ifplugd.c +++ b/networking/ifplugd.c @@ -485,8 +485,10 @@ static smallint detect_link(void) static NOINLINE int check_existence_through_netlink(void) { + int iface_len; char replybuf[1024]; + iface_len = strlen(G.iface); while (1) { struct nlmsghdr *mhdr; ssize_t bytes; @@ -526,8 +528,9 @@ static NOINLINE int check_existence_through_netlink(void) int len = RTA_PAYLOAD(attr); if (len > IFNAMSIZ) len = IFNAMSIZ; - - if (strncmp(G.iface, RTA_DATA(attr), len) == 0) { + if (iface_len <= len + && strncmp(G.iface, RTA_DATA(attr), len) == 0 + ) { G.iface_exists = (mhdr->nlmsg_type == RTM_NEWLINK); } } -- cgit v1.1