summaryrefslogtreecommitdiff
path: root/libbb
AgeCommit message (Collapse)Author
2004-04-07Vladimir N. Oleynik writes:Eric Andersen
Hi. Last changes (rev 1.12) to recursive_actions() by Christian Grigis have problem. Test for demonstrate: $ mkdir aaa bbb ccc $ su # chown root bbb # chmod 700 bbb # exit $ busybox chmod 777 -R . ./bbb: Permision denied But "./ccc" mode not changed. Previous variant works fine, errors skiped and continued recursion. --w vodz
2004-04-06Christian Grigis, christian.grigis at smartdata dot ch writes:Eric Andersen
Hello everyone, Busybox's insmod fails to locate a module when that module is the only one existing in the /lib/modules directory (with a unique name). Example: # find /lib/modules/ -type f /lib/modules/kernel/drivers/char/bios.o # insmod bios insmod: bios.o: no module by that name found # touch /lib/modules/dummy # find /lib/modules/ -type f /lib/modules/kernel/drivers/char/bios.o /lib/modules/dummy # insmod bios Using /lib/modules/kernel/drivers/char/bios.o As long as there is another file in the /lib/modules directory, insmod finds it OK. I tracked the problem down to 'check_module_name_match()' in insmod.c: It returns TRUE when a match is found, and FALSE otherwise. In the case where there is only one module in the /lib/modules directory (or more that one module, but all with the same name), 'recursive_action()' will return TRUE and we end up on line 4196 in 'insmod.c' which returns an error. [The reason it works with more than one module with different names is that in this case there will always be one not matching, 'recursive_action()' will return FALSE and we end up in line 4189.] Now, from the implementation of 'recursive_action()' and from other usages of it (tar.c, etc.), it seems to me that FALSE should be returned to indicate that we want to stop the recursion, so TRUE and FALSE should be inverted in 'check_module_name_match()'. At the same time, 'recursive_action()' continues to recurse even after the recursive call has returned FALSE; again in my understanding and other usages of it, we can safely stop recursing at this point. Here is my patch against 1.00-pre8:
2004-03-27Add missing include filesEric Andersen
2004-03-27s/fileno\(stdin\)/STDIN_FILENO/gEric Andersen
s/fileno\(stdout\)/STDOUT_FILENO/g
2004-03-23Brian Pomerantz writes:Eric Andersen
I've noticed a bug in the "autowidth" feature more, and is probably in others. The call to the function get_terminal_width_height() passes in a file descriptor but that file descriptor is never used, instead the ioctl() is called with 0. In more_main() the call to get_terminal_width_height() passes 0 as the file descriptor instead of fileno(cin). This isn't a problem when you more a file (e.g. "more /etc/passwd") but when you pipe a file to it (e.g. "cat /etc/passwd | more") the size of the terminal cannot be determined because file descriptor 0 is not a terminal. The fix is simple, I've attached a patch for more.c and get_terminal_width_height.c. BAPper
2004-03-15Remove trailing whitespace. Update copyright to include 2004.Eric Andersen
2004-03-10In spite of the feature freeze, check in a complete rework of route whichManuel Novoa III
fixes some bugs, adds some error checking, and removes _lots_ of bloat. Text size on i386... old new ipv6 5425 3523 no ipv6 3143 2193
2004-03-08My bug. :-(Manuel Novoa III
2004-03-06Fix/eliminate use of atolEric Andersen
2004-03-06Don't build these support functions for uClibc, as it always suppliesManuel Novoa III
versions.
2004-03-05Patch from Vernon Sauder.Glenn L McGrath
The off_t type is not a consistent size; it depends on the kernel options (something about large file support). Therefore, the format string for printing an address is not always the same.
2004-02-23bb_full_fd_action was incorrectly returning an error message causingGlenn L McGrath
major breaking.
2004-02-22For the time being, revert the changes for detecting copyingEric Andersen
a directory into itself. It is harder to do this correctly than it appears. Not trying at all seems a better compromise for the time being, untill we can implement this correctly.
2004-02-21Sometimes i get carried away with the use of function pointers, im sureGlenn L McGrath
it seemed like a good idea at the time.
2004-02-19Chris Larson (kergoth) writes:Eric Andersen
As Manuel points out, this is a flawed fix, and doesnt fix the following: mkdir -p cpa cpb cpc cp -a cpa cpa/cpb/cpc Attached what appears to be a more sane fix. Apply on top of previous. Please confirm sanity.
2004-02-19Chris Larson (kergoth) writes:Eric Andersen
I was adding -s/--symbolic-link support to busybox cp when I noticed a bug with -r/-a. Test case: mkdir -p test/out cd test busybox cp -a * out/ Will never return until we run out of open files or similar. Coreutils cp on the other hand will error with "cannot copy a directory, `out', into itself, `out'". Patch attached.
2004-02-13Accomodate the fact that newer libc versions may in fact notEric Andersen
contain query_module and friends and more
2004-02-06Make the loop support stuff be much less evil, and make it copeEric Andersen
with 2.6.x asm/posix_types.h, which has done singularly evil thing by yanking __kernel_dev_t and renaming it. The loop interface was really poorly designed in the first place. The new 64 bit loop interface looks to be somewhat less horrible, too bad it is only present in 2.6.x kernels. -Erik
2004-02-05Vladimir N. Oleynik writes:Eric Andersen
Ok. I found my mistake :( The trivial patch attached. --w vodz
2004-02-04The variable 'complementaly' used to be allocated with calloc, which zeroed itEric Andersen
out during the allocation process. When vodz changed it to be allocated on the stack, he forgot to explicitly zero it, leaving its value filled with whatever used to be sitting on the stack. It would garbage values, depending on the garbage that happened to be sitting on the stack when the function was called. The result was that applets using bb_getopt_ulflags() were showing unpredictable behavior (such as segfaults), which naturally broke many things.
2004-01-30s/u_int/unsigned int/gEric Andersen
s/u_short/unsigned short/g
2004-01-30Use proper C99 types throughout. So not use silly typedefs.Eric Andersen
2004-01-30Support new uClibc stdio core.Manuel Novoa III
2004-01-29Apply a couple of optimizationsEric Andersen
2004-01-27Teach busybox ps to get the correct uid when displaying stuffEric Andersen
2004-01-22Vodz, last_patch_123, patch have new version getopt_ulflags.Glenn L McGrath
- size reduced 34 bytes - don`t use dynamic memory allocation - small indent correction.
2004-01-21Patch from Atsushi Nemoto, recent MIPS kernel headersGlenn L McGrath
does not provide PAGE_SHIFT for userland (because now mips-linux kernel supports PAGESIZE other than 4K).
2004-01-17Modify bb_lookup_port to allow the protocol to be specified, allowingGlenn L McGrath
/etc/services support for inetd, netcat and tftp.
2004-01-13Fix a bug where mount could check the wrong device. st_rdev is the correctEric Andersen
device ID iff the named file is a character or block special device. Otherwise it is meaningless junk, in which case st_dev should be used. This was done incorrectly, which could cause mount to display bogus mount info. -Erik
2004-01-11Patch from Matt Kraai to fix debian bug #227081Glenn L McGrath
cp does not truncate existing destinations. That is, after running echo foo > foo echo fubar > fubar cp foo fubar the contents of fubar are foo r instead of foo
2003-12-23fix broken formattingEric Andersen
2003-12-23don't mess up errnoEric Andersen
2003-12-20bother. It seems I can't read.Eric Andersen
2003-12-20doh!Eric Andersen
2003-12-20Try to accomodate systems that do not define PAGE_SHIFTEric Andersen
2003-12-20Use low level file descriptors to match bb_copyfd_eofGlenn L McGrath
2003-12-20Change interface to bb_lookup_host, dont try and set port inside thisGlenn L McGrath
function as there is no gracefull way of handling failures. Rename bb_getport to bb_lookup_port, allow a default port to be specified so it always returns a correct value. Modify ftpgetput/rdate/wget to use the new interface. wget/rdate now use etc/services with a falback default value.
2003-12-19Allow escaped 8 bit characters in bb_opt_complementalyGlenn L McGrath
2003-12-19Fix a bug preventing use of escaped characters that use the signed bitGlenn L McGrath
2003-12-15Get vfork_daemon_rexec working under uclinuxRuss Dill
2003-11-24When a size of 0 is passed to copyfd_size, dont do anything, it wasGlenn L McGrath
reading untill eof which breaks tar
2003-11-22Fix warningGlenn L McGrath
2003-11-21As we no longer use function pointers for read in common archiving codeGlenn L McGrath
archive_xread can be replaced with bb_full_read, and archive_copy_file with bb_copyfd* bb_copyfd is split into two functions bb_copyfd_size and bb_copyfd_eof, they share a common backend.
2003-11-20Dont over-read fd, use function pointer for hash function.Glenn L McGrath
2003-11-20Superficial changesGlenn L McGrath
2003-11-10Merge common parts of sha1sum and md5sum, which is everything except theGlenn L McGrath
algorithms. Move algorithms to hash_fd and make them available via a common function.
2003-11-03Fix rdate and ftpget/ftpput so they compile with the new xconnect.Eric Andersen
I have checked rdate. Someone should also check ftpget/ftpput to be sure they still work.
2003-10-31Rework wget, the xconnect interface, and its various clientsEric Andersen
in order to fix the problems with round robin DNS reported by Andrew Flegg: http://busybox.net/lists/busybox/2003-October/009579.html This removes the ipv6 specific xconnect dns lookups. I do not see why that would need to be special cased for ipv6 as was done, but that will just have to be tested. So IPV6 people -- please test this change! -Erik
2003-10-22Patch from Arthur Othieno to fix a compiler warningEric Andersen
2003-10-22make this a little bit less messyEric Andersen