summaryrefslogtreecommitdiff
path: root/libbb/procps.c
AgeCommit message (Collapse)Author
2004-08-26Tito writes:Eric Andersen
Hi, I've spent the half night staring at the devilish my_getpwuid and my_getgrgid functions trying to find out a way to avoid actual and future potential buffer overflow problems without breaking existing code. Finally I've found a not intrusive way to do this that surely doesn't break existing code and fixes a couple of problems too. The attached patch: 1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows 2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h. 3) The behaviour of tar, ls and logger is unchanged. 4) The behavior of ps with somewhat longer usernames messing up output is fixed. 5) The only bigger change was the increasing of size of the buffers in id.c to avoid false negatives (unknown user: xxxxxx) with usernames longer than 8 chars. The value i used ( 32 chars ) was taken from the tar header ( see gname and uname). Maybe this buffers can be reduced a bit ( to 16 or whatever ), this is up to you. 6) The increase of size of the binary is not so dramatic: size busybox text data bss dec hex filename 239568 2300 36816 278684 4409c busybox size busybox_fixed text data bss dec hex filename 239616 2300 36816 278732 440cc busybox 7) The behaviour of whoami changed: actually it prints out an username cut down to the size of the buffer. This could be fixed by increasing the size of the buffer as in id.c or avoid the use of my_getpwuid and use getpwuid directly instead. Maybe this colud be also remain unchanged...... Please apply if you think it is ok to do so. The diff applies on today's cvs tarball (2004-08-25). Thanks in advance, Ciao, Tito
2004-01-27Teach busybox ps to get the correct uid when displaying stuffEric Andersen
2004-01-21Patch from Atsushi Nemoto, recent MIPS kernel headersGlenn L McGrath
does not provide PAGE_SHIFT for userland (because now mips-linux kernel supports PAGESIZE other than 4K).
2003-12-20bother. It seems I can't read.Eric Andersen
2003-12-20doh!Eric Andersen
2003-12-20Try to accomodate systems that do not define PAGE_SHIFTEric Andersen
2003-07-03Patch from Russell Coker:Eric Andersen
I've attached my latest SE Linux patch for busybox against the latest CVS version of busybox.
2003-05-26Skip printing "/proc/%d/cmdline" stuff when it is not relevantEric Andersen
2003-03-19Major coreutils update.Manuel Novoa III
2002-12-05Kill CONFIG_FEATURE_USE_DEVPS_PATCH and the devps patch. I'm notEric Andersen
maintaining it anymore, and it is now terribly out of date. -Erik
2002-12-02last_patch_69, 8 bit clean and other fixes from Vladimir N. OleynikGlenn L McGrath
2002-11-25Handle name entries that have a \0 in them, last_patch_65 from Vladimir N. ↵Glenn L McGrath
Oleynik
2002-11-24include libbb after stdlib.h as it breaks dmallocGlenn L McGrath
2002-10-22Patch last_pach62 from vodz. This patch moves all the /proc parsingEric Andersen
code into libbb so it can be shared by ps, top, etc, saving over 1.5k.