summaryrefslogtreecommitdiff
path: root/libbb/interface.c
AgeCommit message (Collapse)Author
2004-08-26Felipe Kellermann writes:Eric Andersen
Unfortunatelly I've not followed the last two or three weeks commits (new semester started and so now I rarely have time to fix my personal bridge) but tonight I synched my tree and immediately noticed a rather nasty bug! [Using libbb/interface.c:1.24] # grep eth0 /proc/net/dev | xargs eth0:311708397 237346 1670 0 1789 1670 0 0 22580308 120297 0 0 0 102 0 0 # ifconfig eth0 eth0 Link encap:Ethernet HWaddr 00:20:AF:7C:EA:B7 inet addr:10.0.0.1 Bcast:10.0.0.127 Mask:255.255.255.128 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) Interrupt:5 Base address:0x320 All values `ifconfig' is showing are `zeroed' -- I quickly looked at the last commits I missed and noticed that there were a commit relating to ifconfig, libbb/interface.c:1.23->1.24 (PatchSet 4338). I've reversed the patch and now everything is working again. I compared the get_name's return values from the 1.23 and 1.24 and quickly noticed that the new revision is leaving `p' right on the sep while the rev 1.23 was leaving it right on the starting of the values... 1-line, 1/3-minute patch attached :-)
2004-08-12Patch from solar to fix problems with get_name()Eric Andersen
2004-07-23Fix for a bug identied by Harald Kuthe, when using many interfaces (29 Glenn L McGrath
in this case) the order was incorrect and there were duplicate entries.
2004-04-14remove a warningEric Andersen
2004-03-15Remove trailing whitespace. Update copyright to include 2004.Eric Andersen
2003-08-29Fix for compiling with ipv6Glenn L McGrath
2003-08-02Save 0.5K.Manuel Novoa III
2003-07-28James Petterson writes:Eric Andersen
I've found a possible bug in libbb/interface.c, in function if_readlist_proc(). This function calls get_name(), and passes as an argument 'name', a buffer of 16 bytes (IFNAMSIZ). The function get_name(), however, may use more than 16 bytes, when it is searching for aliases. Even if you don't have an alias interface, you can run into trouble if the interface has received more than 99999999 bytes, in which case the space between the interface name and the rx stats disappears, as in the /proc/net/dev example below: wan0.200:264573315 462080 ... In this case get_name() correctly identifies the interface name as "wan0.200", but to do that it uses 18 bytes of the 'name' buffer, which could lead to an unpredictable error. A simple solution would be to increase the size of the buffer:
2003-07-22Remove remaining libc5 support codeEric Andersen
2003-07-14Update a bunch of docs. Run a script to update my email addr.Eric Andersen
2003-03-19Major coreutils update.Manuel Novoa III
2003-02-09Fix compiler warnings, patch by Steven ScholzGlenn L McGrath
2003-01-14Eliminate most instances where we use linux kernel headersEric Andersen
-Erik
2002-11-28Use error_msg instead of fprintf(stderr, other minor cleanupsGlenn L McGrath
2002-11-26use #ifdef CONFIG_* instead of #if CONFIG_*Glenn L McGrath
2002-09-17Use "MiB" not "Mb"Eric Andersen
-Erik
2002-08-22Remove duplicate definitions, run through indentGlenn L McGrath
2002-07-03This patch from Bart Visscher <magick@linux-fan.com> addsEric Andersen
IPV6 support to busybox. This patch does the following: * Add IPv6 support to libbb * Enable IPv6 interface address display * Add IPv6 config option * Adds ping6, an adaptation of the ping applet for IPv6 * Adds support routines for ping6: - xgethostbyname2 - create_icmp6_socket * Adds ifconfig support for IPv6 * Add support IPv6 to netstat * Add IPv6 support to route Thanks Bart!
2001-11-10Latest patch from vodz:Eric Andersen
-- reverse resolve network name and cache in route and ifconfig applets, fix print nslookup server name if compile without uClibc, fix route crashe 'route add', fix warnings compile networking and pwd_grp applets
2001-10-27Be extra pedantic about printing the correct type for an addressEric Andersen
2001-10-24Major rework of the directory structure and the entire build system.Eric Andersen
-Erik
2001-07-19Some adjustments, mostly from David McCullough <davidm@lineo.com> toEric Andersen
make busybox be more uClinux friendly. I also adjusted Config.h for uClinux so it will automagically disable apps the arn't going to work without fork() and such. -Erik
2001-06-01Vladimir's last_patch13, containing several bugfixes.Eric Andersen
2001-05-05include libbb.h after other includesGlenn L McGrath
2001-04-19This has two patches. First it moves interface.c to libbb (it isEric Andersen
support code after all). It also contains a patch from Larry Doolittle that removes two instances of "strlen([^)]*) *- *1", un-shadows two variables, relaxes requirement for a sprintf(3) that returns number of bytes written, and eliminates a duplicate subroutine.