summaryrefslogtreecommitdiff
path: root/testsuite/TODO
diff options
context:
space:
mode:
authorDenys Vlasenko2021-12-12 17:13:54 +0100
committerDenys Vlasenko2021-12-12 17:13:54 +0100
commite67b80f4739c4075b51b0a575701b73928fe0bf1 (patch)
tree20c9163f50db185493b7fa7d6e778742c51a3b37 /testsuite/TODO
parent9b678807198611308cfd8b10427f9e08c62f7bec (diff)
downloadbusybox-e67b80f4739c4075b51b0a575701b73928fe0bf1.zip
busybox-e67b80f4739c4075b51b0a575701b73928fe0bf1.tar.gz
udhcpc6: fix udhcp_find_option to actually find DHCP6 options
udhcp_insert_new_option treats code for IPv6 as follows: new->data[D6_OPT_CODE] = code >> 8; new->data[D6_OPT_CODE + 1] = code & 0xff; udhcp_find_option tests the code as follows: while (opt_list && opt_list->data[OPT_CODE] < code) ... if (opt_list && opt_list->data[OPT_CODE] == code) So yes, OPT_CODE and D6_OPT_CODE are both 0, but the D6_OPT_CLIENTID = 1 value means that the 1 is in the seconds byte, and udhcp_find_option is only looking at the first byte, So the send_d6_release can never find it the created option. function old new delta udhcp_find_option 28 53 +25 attach_option 276 284 +8 udhcpc6_main 2602 2607 +5 perform_d6_release 262 267 +5 udhcpd_main 1518 1520 +2 udhcpc_main 2542 2544 +2 add_serverid_and_clientid_options 46 48 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 7/0 up/down: 49/0) Total: 49 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'testsuite/TODO')
0 files changed, 0 insertions, 0 deletions