diff options
author | Denys Vlasenko | 2021-06-05 16:20:05 +0200 |
---|---|---|
committer | Denys Vlasenko | 2021-06-05 16:20:05 +0200 |
commit | 5dadd497ffd9835a2860cf89ad781d1b513803dc (patch) | |
tree | 7ad8eb72b3cd1b5a3d94cd6d2ead9e86f2779c0a /sysklogd | |
parent | d3e1090308b6d3c55e01a2000a743b73605ddd7f (diff) | |
download | busybox-5dadd497ffd9835a2860cf89ad781d1b513803dc.zip busybox-5dadd497ffd9835a2860cf89ad781d1b513803dc.tar.gz |
runsv: robustify signal handling - SIGTERM to child between vfork and exec could mess things up
While at it, rename bb_signals_recursive_norestart() to bb_signals_norestart():
"recursive" was implying we are setting SA_NODEFER allowing signal handler
to be entered recursively, but we do not do that.
function old new delta
bb_signals_norestart - 70 +70
startservice 380 394 +14
bb_signals_recursive_norestart 70 - -70
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/0 up/down: 84/-70) Total: 14 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'sysklogd')
-rw-r--r-- | sysklogd/klogd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sysklogd/klogd.c b/sysklogd/klogd.c index 82596bc..df0edee 100644 --- a/sysklogd/klogd.c +++ b/sysklogd/klogd.c @@ -226,7 +226,7 @@ int klogd_main(int argc UNUSED_PARAM, char **argv) signal(SIGHUP, SIG_IGN); /* We want klogd_read to not be restarted, thus _norestart: */ - bb_signals_recursive_norestart(BB_FATAL_SIGS, record_signo); + bb_signals_norestart(BB_FATAL_SIGS, record_signo); syslog(LOG_NOTICE, "klogd started: %s", bb_banner); |