summaryrefslogtreecommitdiff
path: root/shell
diff options
context:
space:
mode:
authorManuel Novoa III2004-02-01 10:03:05 +0000
committerManuel Novoa III2004-02-01 10:03:05 +0000
commit31b98dd09748535a5004e948bb560c320d179a66 (patch)
tree1eb940e9065e784635878cb7abd2a17f43c2e3e2 /shell
parent083862228a3da88c6890a1a4beba5355367dfd2e (diff)
downloadbusybox-31b98dd09748535a5004e948bb560c320d179a66.zip
busybox-31b98dd09748535a5004e948bb560c320d179a66.tar.gz
Rewrite parse_config_file(). Among the old version's problems:
No checking for lines that were too long. No checking that fgets returning NULL was actually due to EOF. Various whitespace handling inconsistencies. Bloat (switches and multiple identical function calls). Failure to check for trailing characters in some cases. Dynamicly allocated memory was not free()d on error. Given that this controls suid/sgid behavior, the sloppy coding was really inexcusable. :-(
Diffstat (limited to 'shell')
0 files changed, 0 insertions, 0 deletions