summaryrefslogtreecommitdiff
path: root/shell/hush_test
diff options
context:
space:
mode:
authorDenys Vlasenko2016-08-19 18:23:56 +0200
committerDenys Vlasenko2016-08-19 18:43:06 +0200
commit215b0ca6e4fe466c6942d21a1bba62d97f2d5e5d (patch)
tree4fbb9563d870ce8a5f8f08015424e358a1462677 /shell/hush_test
parentaedc3fe19fac368dc363050e0387d263b7e01cc6 (diff)
downloadbusybox-215b0ca6e4fe466c6942d21a1bba62d97f2d5e5d.zip
busybox-215b0ca6e4fe466c6942d21a1bba62d97f2d5e5d.tar.gz
hush: fix a bug in FEATURE_SH_STANDALONE=y config. Closes 9186
Run this in a "sh SCRIPT": sha256sum /dev/null echo END sha256sum is a NOEXEC applet. It runs in a forked child. Then child exit()s. By this time, entire script is read, and buffered in a FILE object from fopen("SCRIPT"). But fgetc() did not consume entire input. exit() lseeks back by -9 bytes, from <eof> to 'e' in 'echo'. (this may be libc-specific). This change of fd position *is shared with the parent*! Now parent can read more, and it thinks there is another "echo END". End result: two "echo END"s are run. Fix this by _exit()ing instead. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'shell/hush_test')
-rwxr-xr-xshell/hush_test/run-all3
1 files changed, 2 insertions, 1 deletions
diff --git a/shell/hush_test/run-all b/shell/hush_test/run-all
index 64a7abc..837b3f7 100755
--- a/shell/hush_test/run-all
+++ b/shell/hush_test/run-all
@@ -64,11 +64,12 @@ do_test()
echo -n "$1/$x:"
(
"$THIS_SH" "./$x" >"$name.xx" 2>&1
+ r=$?
# filter C library differences
sed -i \
-e "/: invalid option /s:'::g" \
"$name.xx"
- test $? -eq 77 && rm -f "../$1-$x.fail" && exit 77
+ test $r -eq 77 && rm -f "../$1-$x.fail" && exit 77
diff -u "$name.xx" "$name.right" >"../$1-$x.fail" && rm -f "$name.xx" "../$1-$x.fail"
)
case $? in