summaryrefslogtreecommitdiff
path: root/shell/hush.c
diff options
context:
space:
mode:
authorDenys Vlasenko2017-08-11 15:41:39 +0200
committerDenys Vlasenko2017-08-11 15:41:39 +0200
commitd16e612c93d1a698c1a9d931b786cf3500996ae3 (patch)
tree2f015bf2f6676a5d6c34edfe153fe5b568a4757f /shell/hush.c
parent9a7d0a01918df5a963b6c90177b321ff743282b2 (diff)
downloadbusybox-d16e612c93d1a698c1a9d931b786cf3500996ae3.zip
busybox-d16e612c93d1a698c1a9d931b786cf3500996ae3.tar.gz
hush: fix redirect code (was using uninitialized variables)
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'shell/hush.c')
-rw-r--r--shell/hush.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/shell/hush.c b/shell/hush.c
index dc05f24..1e58d71 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -6741,7 +6741,8 @@ static struct squirrel *add_squirrel(struct squirrel *sq, int fd, int avoid_fd)
int moved_to;
int i;
- if (sq) for (i = 0; sq[i].orig_fd >= 0; i++) {
+ i = 0;
+ if (sq) for (; sq[i].orig_fd >= 0; i++) {
/* If we collide with an already moved fd... */
if (fd == sq[i].moved_to) {
sq[i].moved_to = fcntl_F_DUPFD(sq[i].moved_to, avoid_fd);
@@ -6769,7 +6770,8 @@ static struct squirrel *add_squirrel_closed(struct squirrel *sq, int fd)
{
int i;
- if (sq) for (i = 0; sq[i].orig_fd >= 0; i++) {
+ i = 0;
+ if (sq) for (; sq[i].orig_fd >= 0; i++) {
/* If we collide with an already moved fd... */
if (fd == sq[i].orig_fd) {
/* Examples: