diff options
| author | Denys Vlasenko | 2017-09-29 18:02:01 +0200 |
|---|---|---|
| committer | Denys Vlasenko | 2017-09-29 18:02:01 +0200 |
| commit | f625836e6059d307e951a60b60f1c9ed259ee983 (patch) | |
| tree | 1e4be21937a6b9d23969b1a4b2ab95428ebcb048 /networking/udhcp/dhcpc.c | |
| parent | a6a3ad327360669e0c12552f680382e3b9713489 (diff) | |
| download | busybox-f625836e6059d307e951a60b60f1c9ed259ee983.zip busybox-f625836e6059d307e951a60b60f1c9ed259ee983.tar.gz | |
udhcpc[6]: make log2 messages for chaddr field indented like the rest
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'networking/udhcp/dhcpc.c')
| -rw-r--r-- | networking/udhcp/dhcpc.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c index 2ae8bcc..4548d4a 100644 --- a/networking/udhcp/dhcpc.c +++ b/networking/udhcp/dhcpc.c @@ -1534,6 +1534,13 @@ int udhcpc_main(int argc UNUSED_PARAM, char **argv) */ if (send_renew(xid, server_addr, requested_ip) >= 0) { timeout >>= 1; +//TODO: the timeout to receive an answer for our renew should not be selected +//with "timeout = lease_seconds / 2; ...; timeout = timeout / 2": it is often huge. +//Waiting e.g. 4*3600 seconds for a reply does not make sense +//(if reply isn't coming, we keep an open socket for hours), +//it should be something like 10 seconds. +//Also, it's probably best to try sending renew in kernel mode a few (3-5) times +//and fall back to raw mode if it does not work. continue; } /* else: error sending. |