summaryrefslogtreecommitdiff
path: root/modutils/insmod.c
diff options
context:
space:
mode:
authorDenis Vlasenko2008-06-24 16:08:22 +0000
committerDenis Vlasenko2008-06-24 16:08:22 +0000
commitfe733a974457dae2126edf6b2e2bae594418ad74 (patch)
treed8ac2b8803f32c7abe8b9f9d84e43a9a373e5d59 /modutils/insmod.c
parent70685bd022855c858682c51da95a07336505536d (diff)
downloadbusybox-fe733a974457dae2126edf6b2e2bae594418ad74.zip
busybox-fe733a974457dae2126edf6b2e2bae594418ad74.tar.gz
changes in comments only
Diffstat (limited to 'modutils/insmod.c')
-rw-r--r--modutils/insmod.c13
1 files changed, 8 insertions, 5 deletions
diff --git a/modutils/insmod.c b/modutils/insmod.c
index f45a594..3fbb02b 100644
--- a/modutils/insmod.c
+++ b/modutils/insmod.c
@@ -4235,12 +4235,15 @@ static int insmod_ng_main(int argc ATTRIBUTE_UNUSED, char **argv)
}
#if 0
- /* Any special reason why mmap? It isn't performace critical... */
-
- /* yes, xmalloc'ing can use *alot* of RAM. Don't forget that there are
+ /* Any special reason why mmap? It isn't performance critical. -vda */
+ /* Yes, xmalloc'ing can use *alot* of RAM. Don't forget that there are
* modules out there that are half a megabyte! mmap()ing is way nicer
- * for small mem boxes, i guess.
- */
+ * for small mem boxes, i guess. */
+ /* But after load, these modules will take up that 0.5mb in kernel
+ * anyway. Using malloc here causes only a transient spike to 1mb,
+ * after module is loaded, we go back to normal 0.5mb usage
+ * (in kernel). Also, mmap isn't magic - when we touch mapped data,
+ * we use memory. -vda */
int fd;
struct stat st;
unsigned long len;