diff options
| author | Denis Vlasenko | 2008-11-09 00:15:11 +0000 |
|---|---|---|
| committer | Denis Vlasenko | 2008-11-09 00:15:11 +0000 |
| commit | 3fa36e235021af5810333a52876d29efc661ad60 (patch) | |
| tree | 71249d42a3a17ebf3c166826b71fe1453dcb6756 /loginutils | |
| parent | 73cc54388daeae391698b8afe788f421cf9e394d (diff) | |
| download | busybox-3fa36e235021af5810333a52876d29efc661ad60.zip busybox-3fa36e235021af5810333a52876d29efc661ad60.tar.gz | |
*: a bit of code shrink
function old new delta
stop_handler 41 38 -3
sulogin_main 508 504 -4
got_cont 4 - -4
cont_handler 11 - -11
startservice 309 297 -12
processorstart 423 409 -14
tcpudpsvd_main 1861 1843 -18
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 0/5 up/down: 0/-66) Total: -66 bytes
Diffstat (limited to 'loginutils')
| -rw-r--r-- | loginutils/login.c | 4 | ||||
| -rw-r--r-- | loginutils/sulogin.c | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/loginutils/login.c b/loginutils/login.c index 70e3b13..a18b4d5 100644 --- a/loginutils/login.c +++ b/loginutils/login.c @@ -486,8 +486,8 @@ int login_main(int argc UNUSED_PARAM, char **argv) // If this stuff is really needed, add it and explain why! /* Set signals to defaults */ - /*signal(SIGALRM, SIG_DFL); - not needed, we already set it - * to non-SIG_IGN, and on exec such signals are reset to SIG_DFL */ + /* Non-ignored signals revert to SIG_DFL on exec anyway */ + /*signal(SIGALRM, SIG_DFL);*/ /* Is this correct? This way user can ctrl-c out of /etc/profile, * potentially creating security breach (tested with bash 3.0). diff --git a/loginutils/sulogin.c b/loginutils/sulogin.c index bfd4256..892c434 100644 --- a/loginutils/sulogin.c +++ b/loginutils/sulogin.c @@ -32,11 +32,12 @@ int sulogin_main(int argc UNUSED_PARAM, char **argv) opt_complementary = "t+"; /* -t N */ getopt32(argv, "t:", &timeout); + argv += optind; - if (argv[optind]) { + if (argv[0]) { close(0); close(1); - dup(xopen(argv[optind], O_RDWR)); + dup(xopen(argv[0], O_RDWR)); close(2); dup(0); } |