diff options
author | Eric Andersen | 2003-06-20 09:01:58 +0000 |
---|---|---|
committer | Eric Andersen | 2003-06-20 09:01:58 +0000 |
commit | 8876fb2f59a0b515b3121d5894933eef88ce566a (patch) | |
tree | f67de9320202043aca8ded20fb80d668c3b0c2d8 /coreutils/dd.c | |
parent | dfce3536ace2bcd38bdd3731841998ce344d786e (diff) | |
download | busybox-8876fb2f59a0b515b3121d5894933eef88ce566a.zip busybox-8876fb2f59a0b515b3121d5894933eef88ce566a.tar.gz |
last_patch89 from vodz:
Manuel,
I rewrite bb_getopt_ulflags() function for more universal usage.
My version support now:
- options with arguments (optional arg as GNU extension also)
- complementaly and/or incomplementaly and/or incongruously and/or list
options
- long_opt (all applets may have long option, add supporting is trivial)
This realisation full compatibile from your version.
Code size grow 480 bytes, but only coreutils/* over compensate this size
after using new function. Last patch reduced over 800 bytes and not full
applied to all. "mkdir" and "mv" applets have long_opt now for demonstrate
trivial addition support long_opt with usage new bb_getopt_ulflags().
Complementaly and/or incomplementaly and/or incongruously and/or list options
logic is not trivial, but new "cut" and "grep" applets using this logic
for examples with full demostrating. New "grep" applet reduced over 300
bytes.
Mark,
Also. I removed bug from "grep" applet.
$ echo a b | busybox grep -e a b
a b
a b
But right is printing one only.
--w
vodz
Diffstat (limited to 'coreutils/dd.c')
-rw-r--r-- | coreutils/dd.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/coreutils/dd.c b/coreutils/dd.c index 1150861..cd97b24 100644 --- a/coreutils/dd.c +++ b/coreutils/dd.c @@ -106,9 +106,7 @@ int dd_main(int argc, char **argv) buf = xmalloc(bs); if (infile != NULL) { - if ((ifd = open(infile, O_RDONLY)) < 0) { - bb_perror_msg_and_die("%s", infile); - } + ifd = bb_xopen(infile, O_RDONLY); } else { ifd = STDIN_FILENO; infile = bb_msg_standard_input; |