summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko2021-09-17 17:32:30 +0200
committerDenys Vlasenko2021-09-17 17:33:32 +0200
commit6d2463ac01dd88cc4359ebbeae9cd757ce037c2b (patch)
tree4d204f224635c13193213ab8e38cb15b209ea342
parent6279aec03d4677424408a515a57aa83664b81311 (diff)
downloadbusybox-6d2463ac01dd88cc4359ebbeae9cd757ce037c2b.zip
busybox-6d2463ac01dd88cc4359ebbeae9cd757ce037c2b.tar.gz
libbb/lineedit: do not escape %^=+}]:, escape ~? in tab completion
function old new delta .rodata 104185 104180 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--libbb/lineedit.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/libbb/lineedit.c b/libbb/lineedit.c
index 68d19e1..e8d721e 100644
--- a/libbb/lineedit.c
+++ b/libbb/lineedit.c
@@ -1133,7 +1133,16 @@ static void showfiles(void)
static const char *is_special_char(char c)
{
- return strchr(" `\"#$%^&*()=+{}[]:;'|\\<>", c);
+ // {: It's mandatory to escape { only if entire name is "{"
+ // (otherwise it's not special. Example: file named "{ "
+ // can be escaped simply as "{\ "; "{a" or "a{" need no escaping),
+ // or if shell supports brace expansion
+ // (ash doesn't, hush optionally does).
+ // (): unlike {, shell treats () specially even in contexts
+ // where they clearly are not valid (e.g. "echo )" is an error).
+ // #: needs escaping to not start a shell comment.
+ return strchr(" `'\"\\#$~?*[{()&;|<>", c);
+ // Used to also have %^=+}]: but not necessary to escape?
}
static char *quote_special_chars(char *found)