diff options
| author | Eric Andersen | 2004-05-05 19:39:21 +0000 |
|---|---|---|
| committer | Eric Andersen | 2004-05-05 19:39:21 +0000 |
| commit | 6c0396ba2ab4bf10535ef43c486c1836786fc97e (patch) | |
| tree | b18a523a463a9ca06a9c85fbb16305c87da22cce | |
| parent | aaff79a8dd00f2a9652a4bce8fbfe77715804ac2 (diff) | |
| download | busybox-6c0396ba2ab4bf10535ef43c486c1836786fc97e.zip busybox-6c0396ba2ab4bf10535ef43c486c1836786fc97e.tar.gz | |
Steve Grubb writes:
Hi,
I just re-reviewed the patch I just sent...and it needed to be BUFSIZ-3 in
dos2unix.c . tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. The loop
increments by 2. That's why it should be BUFSIZ-3.
Best Regards,
Steve Grubb
| -rw-r--r-- | coreutils/dos2unix.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/coreutils/dos2unix.c b/coreutils/dos2unix.c index c8cebce..df0b4f9 100644 --- a/coreutils/dos2unix.c +++ b/coreutils/dos2unix.c @@ -64,7 +64,9 @@ static int convert(char *fn, int ConvType) c = strlen(tempFn); tempFn[c] = '.'; while(1) { - if (c >=BUFSIZ-2) + /* tempFn is BUFSIZ so the last addressable spot it BUFSIZ-1. + * The loop increments by 2. So this must check for BUFSIZ-3. */ + if (c >=BUFSIZ-3) bb_error_msg_and_die("unique name not found"); /* Get some semi random stuff to try and make a * random filename based (and in the same dir as) |