summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVladislav Grishenko2015-03-19 16:19:35 +0500
committerDenys Vlasenko2015-03-22 17:59:34 +0100
commit4d15068d83054a9f82b3f8842706cd6deb401e25 (patch)
tree8becf05987b05a43bf6e56b674d65e7adac9805f
parent911db16229d41f53b9c44272fcccdb3552a5a99e (diff)
downloadbusybox-4d15068d83054a9f82b3f8842706cd6deb401e25.zip
busybox-4d15068d83054a9f82b3f8842706cd6deb401e25.tar.gz
zcip: fix wrong comparison of source IP with our IP
Commit "zcip: fix link-local IP conflict detection" has introduced wrong comparsion of source IP with our IP. This leads to a new IP being picked unnecessarily on every incoming ARP packet. Signed-off-by: Vladislav Grishenko <themiron@mail.ru> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--networking/zcip.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/networking/zcip.c b/networking/zcip.c
index a3307c5..962ba2e 100644
--- a/networking/zcip.c
+++ b/networking/zcip.c
@@ -521,7 +521,7 @@ int zcip_main(int argc UNUSED_PARAM, char **argv)
target_ip_conflict = 0;
if (memcmp(&p.arp.arp_sha, &eth_addr, ETH_ALEN) != 0) {
- if (memcmp(p.arp.arp_spa, &ip.s_addr, sizeof(struct in_addr))) {
+ if (memcmp(p.arp.arp_spa, &ip.s_addr, sizeof(struct in_addr)) == 0) {
/* A probe or reply with source_ip == chosen ip */
source_ip_conflict = 1;
}