diff options
| author | Timo Teräs | 2017-07-14 09:59:52 +0200 |
|---|---|---|
| committer | Denys Vlasenko | 2017-07-14 09:59:52 +0200 |
| commit | cc86b2ad965bff071185edbb77b5a6ea45023e43 (patch) | |
| tree | 5c0d8effa582b85170875cd538eed63090290a59 | |
| parent | a2bdc5c55485b054088513083ca0c78ce11445a9 (diff) | |
| download | busybox-cc86b2ad965bff071185edbb77b5a6ea45023e43.zip busybox-cc86b2ad965bff071185edbb77b5a6ea45023e43.tar.gz | |
add-remove-shell: fix crash when shell is already added
Avoid dereferencing 'don_add' in strcmp since it is invalid
pointer.
Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| -rw-r--r-- | loginutils/add-remove-shell.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/loginutils/add-remove-shell.c b/loginutils/add-remove-shell.c index 922b333..54b62c7 100644 --- a/loginutils/add-remove-shell.c +++ b/loginutils/add-remove-shell.c @@ -84,7 +84,7 @@ int add_remove_shell_main(int argc UNUSED_PARAM, char **argv) while ((line = xmalloc_fgetline(orig_fp)) != NULL) { char **cpp = argv; while (*cpp) { - if (strcmp(*cpp, line) == 0) { + if (*cpp != dont_add && strcmp(*cpp, line) == 0) { /* Old file has this shell name */ if (REMOVE_SHELL) { /* we are remove-shell */ |