diff options
| author | Denys Vlasenko | 2015-10-12 03:12:17 +0200 |
|---|---|---|
| committer | Denys Vlasenko | 2015-10-12 03:12:17 +0200 |
| commit | c8e5ead03ac97da5b8a864481c8a790cfe8dfe4d (patch) | |
| tree | 68b49cc0e7bf184c32613637e8d53ae04fe39b2a | |
| parent | 2dbbf823efe2e74458d5927e6b21310d72266b0f (diff) | |
| download | busybox-c8e5ead03ac97da5b8a864481c8a790cfe8dfe4d.zip busybox-c8e5ead03ac97da5b8a864481c8a790cfe8dfe4d.tar.gz | |
build system: remove special-casing for extra libs
It is not reliable (tried on three systems, multiple problems).
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| -rw-r--r-- | Config.in | 8 | ||||
| -rw-r--r-- | Makefile.flags | 25 |
2 files changed, 11 insertions, 22 deletions
@@ -514,14 +514,6 @@ config PIE Most people will leave this set to 'N'. -config LINK_WITH_PTHREAD - bool "Link with pthread library" - default n - help - On some systems, some libraries (such as crypt) also require pthread. - - Select this only if your build otherwise fails. - config NOMMU bool "Force NOMMU build" default n diff --git a/Makefile.flags b/Makefile.flags index b6cd32e..9f77674 100644 --- a/Makefile.flags +++ b/Makefile.flags @@ -129,22 +129,19 @@ else LDLIBS += m endif -ifeq ($(CONFIG_LINK_WITH_PTHREAD),y) -PTHREAD_AVAILABLE := $(shell echo 'int main(void){return 0;}' >pthreadtest.c; $(CC) $(CFLAGS) -lpthread -o /dev/null pthreadtest.c >/dev/null 2>&1 && echo "y"; rm pthreadtest.c) -ifeq ($(PTHREAD_AVAILABLE),y) -LDLIBS += pthread -endif -endif +# libpam may use libpthread, libdl and/or libaudit. +# On some platforms that requires an explicit -lpthread, -ldl, -laudit. +# However, on *other platforms* it fails when some of those flags +# given needlessly. On some systems, crypt needs pthread. +# +# I even had a system where a runtime test for pthread +# (similar to CRYPT_AVAILABLE test above) was not reliable. +# +# Do not propagate this mess by adding libraries to CONFIG_PAM/CRYPT_AVAILABLE blocks. +# Add libraries you need to CONFIG_EXTRA_LDLIBS instead. ifeq ($(CONFIG_PAM),y) -# libpam uses libpthread, libdl and libaudit, so for static builds busybox -# must be linked to libpthread, libdl and libaudit. On some platforms that -# requires an explicit -lpthread, -ldl and -laudit, so it should be in -# LDLIBS. For non-static builds, scripts/trylink will take care of removing -# these flags if possible. (Not bothering to check CONFIG_STATIC because -# even in a non-static build it could be that the only libpam available is -# libpam.a, so -lpthread & Co. could still be needed.) -LDLIBS += pam pam_misc pthread dl audit +LDLIBS += pam pam_misc endif ifeq ($(CONFIG_SELINUX),y) |