summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Foley2019-01-02 13:09:45 -0800
committerDenys Vlasenko2019-01-21 13:22:31 +0100
commitb7928e18b14a2bc2aa27f82b80803fdff68c328a (patch)
tree85bb9458e9e48a09089bf4470e988e3ac2dad3d2
parent1c42c18e9601ee1416d61663f5a91874954c524d (diff)
downloadbusybox-b7928e18b14a2bc2aa27f82b80803fdff68c328a.zip
busybox-b7928e18b14a2bc2aa27f82b80803fdff68c328a.tar.gz
sed: Fix backslash parsing for 'w' command arg
If there's any whitespace between w and the filename, parse_file_cmd writes to the wrong offset when trying to fix up backslashes. This can be seen in the asan build with busybox sed -e 'w 0\\' Signed-off-by: Brian Foley <bpfoley@google.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--editors/sed.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/editors/sed.c b/editors/sed.c
index 1054c13..cddb0c7 100644
--- a/editors/sed.c
+++ b/editors/sed.c
@@ -387,7 +387,7 @@ static int parse_file_cmd(/*sed_cmd_t *sed_cmd,*/ const char *filecmdstr, char *
bb_error_msg_and_die("empty filename");
*retval = xstrndup(filecmdstr+start, idx-start+hack+1);
if (hack)
- (*retval)[idx] = '\\';
+ (*retval)[idx-start] = '\\';
return idx;
}