summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko2020-11-01 18:47:24 +0100
committerDenys Vlasenko2020-11-01 18:47:24 +0100
commit64981b4c8e88812c322bee3832f1d421ff670ed5 (patch)
treed006cbaab733a481ce753a3f900980a78e85badc
parenta7c065354f820560621aa5f2e90498d6636f41c3 (diff)
downloadbusybox-64981b4c8e88812c322bee3832f1d421ff670ed5.zip
busybox-64981b4c8e88812c322bee3832f1d421ff670ed5.tar.gz
hush: document bugs in [[ =~ ]] comparison
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/hush_test/hush-bugs/strops5_bug.right2
-rwxr-xr-xshell/hush_test/hush-bugs/strops5_bug.tests10
-rw-r--r--shell/hush_test/hush-test2/strops5.right3
-rwxr-xr-xshell/hush_test/hush-test2/strops5.tests13
4 files changed, 28 insertions, 0 deletions
diff --git a/shell/hush_test/hush-bugs/strops5_bug.right b/shell/hush_test/hush-bugs/strops5_bug.right
new file mode 100644
index 0000000..aba7bb4
--- /dev/null
+++ b/shell/hush_test/hush-bugs/strops5_bug.right
@@ -0,0 +1,2 @@
+4:no:1
+5:YES:0
diff --git a/shell/hush_test/hush-bugs/strops5_bug.tests b/shell/hush_test/hush-bugs/strops5_bug.tests
new file mode 100755
index 0000000..3e24df7
--- /dev/null
+++ b/shell/hush_test/hush-bugs/strops5_bug.tests
@@ -0,0 +1,10 @@
+v='*.z'
+
+# Buggy:
+# the problem is that expansion rules of LHS and RHS of ~=
+# should not be the same: in RHS, "$v" and "*" should escape metas
+# (currently "$v" does not),
+# but in LHS, they should _not_ do that
+# (currently "*" does). Thus these cases fail:
+[[ a.z == "$v" ]]; echo 4:no:$? # BUG: "$v" expands to *.z
+[[ "*".z == ?.z ]]; echo 5:YES:$? # BUG: "*" expands to \*
diff --git a/shell/hush_test/hush-test2/strops5.right b/shell/hush_test/hush-test2/strops5.right
new file mode 100644
index 0000000..9ed4d65
--- /dev/null
+++ b/shell/hush_test/hush-test2/strops5.right
@@ -0,0 +1,3 @@
+1:YES:0
+2:no:1
+3:YES:0
diff --git a/shell/hush_test/hush-test2/strops5.tests b/shell/hush_test/hush-test2/strops5.tests
new file mode 100755
index 0000000..ee01e5c
--- /dev/null
+++ b/shell/hush_test/hush-test2/strops5.tests
@@ -0,0 +1,13 @@
+v='*.z'
+[[ a.z = *.z ]]; echo 1:YES:$?
+[[ a.z = "*".z ]]; echo 2:no:$?
+[[ a.z == $v ]]; echo 3:YES:$?
+
+# Buggy:
+# the problem is that expansion rules of LHS and RHS of ~=
+# should not be the same: in RHS, "$v" and "*" should escape metas
+# (currently "$v" does not),
+# but in LHS, they should _not_ do that
+# (currently "*" does). Thus these cases fail:
+#[[ a.z == "$v" ]]; echo 4:no:$? # BUG: "$v" expands to *.z
+#[[ "*".z == ?.z ]]; echo 5:YES:$? # BUG: "*" expands to \*