summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko2017-08-03 19:56:29 +0200
committerDenys Vlasenko2017-08-03 19:56:29 +0200
commitcfd392bea9f52539baae9be4833075e464075958 (patch)
tree877a1408e3be6fa135da89def1d6d4fde870eefa
parent19c9f31af17f2c34e93c9c322b5c546ffbcda6ad (diff)
downloadbusybox-cfd392bea9f52539baae9be4833075e464075958.zip
busybox-cfd392bea9f52539baae9be4833075e464075958.tar.gz
ash: add a fixme comment at run_nofork_applet
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/ash.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/shell/ash.c b/shell/ash.c
index b285e3d..8c9f4ad 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -9918,11 +9918,13 @@ evalcommand(union node *cmd, int flags)
if (applet_no >= 0 && APPLET_IS_NOFORK(applet_no)) {
listsetvar(varlist.list, VEXPORT|VSTACK);
/* run <applet>_main() */
+//FIXME: do we need INT_OFF / INT_ON here?
+//wouldn't open files and allocations leak on ^C otherwise?
status = run_nofork_applet(applet_no, argv);
break;
}
#endif
- /* Can we avoid forking off? For example, very last command
+ /* Can we avoid forking? For example, very last command
* in a script or a subshell does not need forking,
* we can just exec it.
*/