summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenis Vlasenko2006-11-21 21:35:14 +0000
committerDenis Vlasenko2006-11-21 21:35:14 +0000
commit428f7ae6e2817ea438551afc25ce166a175f6c09 (patch)
treeebbe779b373173ff4489cc1e8d7b7c8eb14b989a
parent8b45837b4c07ea5165f7e94d5895b90f9072c4f0 (diff)
downloadbusybox-428f7ae6e2817ea438551afc25ce166a175f6c09.zip
busybox-428f7ae6e2817ea438551afc25ce166a175f6c09.tar.gz
httpd: comment on QUERY_STRING
-rw-r--r--networking/httpd.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/networking/httpd.c b/networking/httpd.c
index cafa9ed..b82e9f9 100644
--- a/networking/httpd.c
+++ b/networking/httpd.c
@@ -1039,9 +1039,13 @@ static int sendCgi(const char *url,
setenv1("SCRIPT_FILENAME", realpath_buff);
/* set SCRIPT_NAME as full path: /cgi-bin/dirs/script.cgi */
setenv1("SCRIPT_NAME", purl);
- /* TODO: bug 996 says we need to decodeString(config->query)
- * before placing it into env. Is this true? Add example
- * in the comment please... */
+ /* http://hoohoo.ncsa.uiuc.edu/cgi/env.html:
+ * QUERY_STRING: The information which follows the ? in the URL
+ * which referenced this script. This is the query information.
+ * It should not be decoded in any fashion. This variable
+ * should always be set when there is query information,
+ * regardless of command line decoding. */
+ /* (Older versions of bbox seemed to do some decoding) */
setenv1("QUERY_STRING", config->query);
setenv1("SERVER_SOFTWARE", httpdVersion);
putenv("SERVER_PROTOCOL=HTTP/1.0");