summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko2017-07-06 20:57:37 +0200
committerDenys Vlasenko2017-07-06 20:57:37 +0200
commit50b8b2914b7551b4e36518fcc70aac201d46d7cb (patch)
tree0c8c9a65c10fec5323d0ff8dd0374b89c5d12d0f
parenta107ef2a6ace98c51473dc3153564a44b260bc6f (diff)
downloadbusybox-50b8b2914b7551b4e36518fcc70aac201d46d7cb.zip
busybox-50b8b2914b7551b4e36518fcc70aac201d46d7cb.tar.gz
hush: add a TODO about redir3.tests failure
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/hush.c4
-rw-r--r--shell/hush_test/hush-redir/redir3.right3
-rwxr-xr-xshell/hush_test/hush-redir/redir3.tests5
3 files changed, 12 insertions, 0 deletions
diff --git a/shell/hush.c b/shell/hush.c
index 0ade2cc..4ba6b3f 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -7723,6 +7723,10 @@ static NOINLINE int run_pipe(struct pipe *pi)
unset_vars(new_env);
add_vars(old_vars);
/* clean_up_and_ret0: */
+
+//FIXME: this restores stdio fds, but does not close other redirects!
+//Example: after "echo TEST 9>/dev/null" fd#9 is not closed!
+//The squirreling code needs rework to remember all fds, not just 0,1,2.
restore_redirects(squirrel);
clean_up_and_ret1:
free(argv_expanded);
diff --git a/shell/hush_test/hush-redir/redir3.right b/shell/hush_test/hush-redir/redir3.right
new file mode 100644
index 0000000..fd641a8
--- /dev/null
+++ b/shell/hush_test/hush-redir/redir3.right
@@ -0,0 +1,3 @@
+TEST
+./redir3.tests: line 4: 9: Bad file descriptor
+Output to fd#9: 1
diff --git a/shell/hush_test/hush-redir/redir3.tests b/shell/hush_test/hush-redir/redir3.tests
new file mode 100755
index 0000000..e37d5e4
--- /dev/null
+++ b/shell/hush_test/hush-redir/redir3.tests
@@ -0,0 +1,5 @@
+# redirects to closed descriptors should not leave these descriptors
+# open afterwards
+echo TEST 9>/dev/null
+echo MUST ERROR OUT >&9
+echo "Output to fd#9: $?"