summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko2016-10-25 18:12:15 +0200
committerDenys Vlasenko2016-10-25 18:12:15 +0200
commit960ca385b721400082323da7f8cddb7f3cfb3027 (patch)
tree99774852252f72d4769555e35516fcba24c6097c
parent6a94cee409e4e2f4394d022703bfbe402c3cdee5 (diff)
downloadbusybox-960ca385b721400082323da7f8cddb7f3cfb3027.zip
busybox-960ca385b721400082323da7f8cddb7f3cfb3027.tar.gz
ash: add comment explaining "set -e; $(cmd)" discrepancy
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/ash.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/shell/ash.c b/shell/ash.c
index cf48b77..79439bf 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -5924,6 +5924,14 @@ evalbackcmd(union node *n, struct backcmd *result)
copyfd(pip[1], 1 | COPYFD_EXACT);
close(pip[1]);
}
+/* TODO: eflag clearing makes the following not abort:
+ * ash -c 'set -e; z=$(false;echo foo); echo $z'
+ * which is what bash does (unless it is in POSIX mode).
+ * dash deleted "eflag = 0" line in the commit
+ * Date: Mon, 28 Jun 2010 17:11:58 +1000
+ * [EVAL] Don't clear eflag in evalbackcmd
+ * For now, preserve bash-like behavior, it seems to be somewhat more useful:
+ */
eflag = 0;
evaltree(n, EV_EXIT); /* actually evaltreenr... */
/* NOTREACHED */