diff options
| author | Ingo van Lil | 2018-01-05 15:04:23 +0100 |
|---|---|---|
| committer | Denys Vlasenko | 2018-02-14 17:38:29 +0100 |
| commit | 59675c625d6500a9a0657481321954b0d1f63da9 (patch) | |
| tree | 51e25a6b447a862064d599e70a250467fd391639 | |
| parent | c0fab1ba496e27168898c0e74d8e3d11b9902999 (diff) | |
| download | busybox-59675c625d6500a9a0657481321954b0d1f63da9.zip busybox-59675c625d6500a9a0657481321954b0d1f63da9.tar.gz | |
ash: fail if 'shift' operand is out of range
If the numeric argument passed to ash's 'shift' built-in is greater than
'$#' the command performs no operation and exits successfully. It should
return a non-zero exit code instead:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#shift
This is consistent with bash and hush.
function old new delta
shiftcmd 122 120 -2
Signed-off-by: Ingo van Lil <inguin@gmx.de>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| -rw-r--r-- | shell/ash.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/shell/ash.c b/shell/ash.c index dfb7d4d..b73a799 100644 --- a/shell/ash.c +++ b/shell/ash.c @@ -10858,7 +10858,7 @@ shiftcmd(int argc UNUSED_PARAM, char **argv) if (argv[1]) n = number(argv[1]); if (n > shellparam.nparam) - n = 0; /* bash compat, was = shellparam.nparam; */ + return 1; INT_OFF; shellparam.nparam -= n; for (ap1 = shellparam.p; --n >= 0; ap1++) { |