diff options
| author | Bernhard Reutner-Fischer | 2006-06-04 16:05:02 +0000 |
|---|---|---|
| committer | Bernhard Reutner-Fischer | 2006-06-04 16:05:02 +0000 |
| commit | 863073da0858b07149d4c15d13d1ac0b1a769eb0 (patch) | |
| tree | 8f3d93ba1eaf148433dcba0078fcc344ddcb2f00 | |
| parent | 395010b1f05911ddcba304bc591ec58950f118c9 (diff) | |
| download | busybox-863073da0858b07149d4c15d13d1ac0b1a769eb0.zip busybox-863073da0858b07149d4c15d13d1ac0b1a769eb0.tar.gz | |
- add note about removing superfluous fmt specifiers
| -rw-r--r-- | TODO | 9 |
1 files changed, 7 insertions, 2 deletions
@@ -259,12 +259,17 @@ Minor stuff: if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2); Unfortunately, that needs linux/watchdog.h and that contains unfiltered kernel types on some distros, which breaks the build. - +--- use bb_error_msg where appropriate: See egrep "(printf.*\([[:space:]]*(stderr|2)|[^_]write.*\([[:space:]]*(stderr|2))" - +--- use bb_perror_msg where appropriate: See egrep "[^_]perror" +--- + Remove superfluous fmt occurances: e.g. + fprintf(stderr, "%s: %s not found\n", "unalias", *argptr); + -> fprintf(stderr, "unalias: %s not found\n", *argptr); +--- Code cleanup: |