diff options
| author | Selva Nair | 2018-08-07 22:44:31 -0400 |
|---|---|---|
| committer | Gert Doering | 2018-08-08 09:35:34 +0200 |
| commit | 7a8109023f4c345fe12f23421c5fa7e88e1ea85b (patch) | |
| tree | dd581d3d03b4dc6cddea3bb9df61915934c81183 /src | |
| parent | da0a42ca98623487726162b8710690cd3d003a63 (diff) | |
| download | openvpn-7a8109023f4c345fe12f23421c5fa7e88e1ea85b.zip openvpn-7a8109023f4c345fe12f23421c5fa7e88e1ea85b.tar.gz | |
Accept empty password and/or response in auth-pam plugin
In the auth-pam plugin correctly parse the static challenge string
even when password or challenge response is empty.
Whether an empty user input is an error is determined by the PAM
conversation function depending on whether the PAM module queries
for it or not.
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1533696271-21799-2-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17382.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/auth-pam/auth-pam.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c index 1324307..88b5320 100644 --- a/src/plugins/auth-pam/auth-pam.c +++ b/src/plugins/auth-pam/auth-pam.c @@ -310,11 +310,11 @@ split_scrv1_password(struct user_pass *up) *resp++ = '\0'; int n = plugin_base64_decode(pass, up->password, sizeof(up->password)-1); - if (n > 0) + if (n >= 0) { up->password[n] = '\0'; n = plugin_base64_decode(resp, up->response, sizeof(up->response)-1); - if (n > 0) + if (n >= 0) { up->response[n] = '\0'; if (DEBUG(up->verb)) |