diff options
| author | Timo Rothenpieler | 2023-01-18 15:24:28 +0100 |
|---|---|---|
| committer | Gert Doering | 2023-01-19 08:40:09 +0100 |
| commit | 99a098e13a427e72ade5ef2812b7ea342ea64aa6 (patch) | |
| tree | 6f58d28130326c93f6ab3497c07e5f7f04639c18 /src | |
| parent | eb85961e72c927256ce9267a43f3519d3ab4edcb (diff) | |
| download | openvpn-99a098e13a427e72ade5ef2812b7ea342ea64aa6.zip openvpn-99a098e13a427e72ade5ef2812b7ea342ea64aa6.tar.gz | |
Don't clear capability bounding set on capng_change_id
The bounding set being empty will overpower the likes of su/sudo
and will make it impossible for any child processes to ever gain
additional privileges again.
Github: fixes OpenVPN/openvpn#220
Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230118142428.162-1-timo@rothenpieler.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26048.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit d8523119b95db55d2c101b8364ce7e9d0d0f6f3a)
Diffstat (limited to 'src')
| -rw-r--r-- | src/openvpn/platform.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/platform.c b/src/openvpn/platform.c index 1b5fa9a..580c4cb 100644 --- a/src/openvpn/platform.c +++ b/src/openvpn/platform.c @@ -246,7 +246,7 @@ platform_user_group_set(const struct platform_state_user *user_state, /* Change to new UID/GID. * capng_change_id() internally calls capng_apply() to apply prepared capabilities. */ - res = capng_change_id(new_uid, new_gid, CAPNG_DROP_SUPP_GRP | CAPNG_CLEAR_BOUNDING); + res = capng_change_id(new_uid, new_gid, CAPNG_DROP_SUPP_GRP); if (res == -4 || res == -6) { /* -4 and -6 mean failure of setuid/gid respectively. |