diff options
| author | Selva Nair | 2019-07-26 23:12:21 -0400 |
|---|---|---|
| committer | Gert Doering | 2019-07-28 22:02:43 +0200 |
| commit | eed67cf0e7f6cbe596495c2f83aeea7c15db0d6e (patch) | |
| tree | 3eb593e78b40cb29a725499ee57fc911ee1baf6a /src | |
| parent | 5fd3d1d58ef0e26616e34a9144d0c984cf435444 (diff) | |
| download | openvpn-eed67cf0e7f6cbe596495c2f83aeea7c15db0d6e.zip openvpn-eed67cf0e7f6cbe596495c2f83aeea7c15db0d6e.tar.gz | |
Correct the return value of cryptoapi RSA signature callbacks
Fixes the wrong check on siglen instead of *siglen for
signing failures.
Bug reported by: lilulo <lilulo@gmail.com>
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Steffan Karger <steffan.karger@fox-it.com>
Message-Id: <1564197141-30513-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18708.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'src')
| -rw-r--r-- | src/openvpn/cryptoapi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c index 720fce0..35a9ebc 100644 --- a/src/openvpn/cryptoapi.c +++ b/src/openvpn/cryptoapi.c @@ -393,7 +393,7 @@ rsa_sign_CNG(int type, const unsigned char *m, unsigned int m_len, } *siglen = priv_enc_CNG(cd, alg, m, (int)m_len, sig, RSA_size(rsa), padding); - return (siglen == 0) ? 0 : 1; + return (*siglen == 0) ? 0 : 1; } /* decrypt */ |