diff options
| author | Selva Nair | 2020-02-19 20:56:43 -0500 |
|---|---|---|
| committer | Gert Doering | 2020-04-15 19:42:14 +0200 |
| commit | df5ea7f1b87012414d2625d1562715887ad1686d (patch) | |
| tree | 5645553f19ce95a41a839d25f3cb8516f2f25a77 /src | |
| parent | 1d9e0be2a7733b0efb0556d187a36912606a9d97 (diff) | |
| download | openvpn-df5ea7f1b87012414d2625d1562715887ad1686d.zip openvpn-df5ea7f1b87012414d2625d1562715887ad1686d.tar.gz | |
Fix possible access of uninitialized pipe handles
Compile time warning for openvpnserv.exe
interactive.c: In function ‘RunOpenvpn’:
interactive.c:160:27: warning: ‘svc_pipe’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
When RunOpenvpn exits early due to errors, uninitialized svc_pipe and
ovpn_pipe vars could get passed to CloseHandleEx(). Fix by initializing
to NULL.
Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Message-Id: <1582163803-3342-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19480.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
(cherry picked from commit 32723d29b2775d63d3fe329d017e7a08e0cdcb72)
Diffstat (limited to 'src')
| -rw-r--r-- | src/openvpnserv/interactive.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index a2b3b20..aecbd84 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1349,7 +1349,7 @@ static DWORD WINAPI RunOpenvpn(LPVOID p) { HANDLE pipe = p; - HANDLE ovpn_pipe, svc_pipe; + HANDLE ovpn_pipe = NULL, svc_pipe = NULL; PTOKEN_USER svc_user = NULL, ovpn_user = NULL; HANDLE svc_token = NULL, imp_token = NULL, pri_token = NULL; HANDLE stdin_read = NULL, stdin_write = NULL; |