diff options
author | Yegor Yefremov | 2015-04-20 16:30:56 +0200 |
---|---|---|
committer | Gert Doering | 2015-05-31 14:19:43 +0200 |
commit | 7d30696ac51aa9649f2290ada2c0fb5865cfe859 (patch) | |
tree | 7f29d9a6e0411cfbfa43932ca9be879a413b5f6f /contrib | |
parent | 859f6aaac6ef35c54306b6f10d2ec902dd41c89b (diff) | |
download | openvpn-7d30696ac51aa9649f2290ada2c0fb5865cfe859.zip openvpn-7d30696ac51aa9649f2290ada2c0fb5865cfe859.tar.gz |
cert_data: fix memory leak
Release pCertName, if SecCertificateCopyValues() fails.
Found via cppcheck.
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Vasily Kulikov <segoon@openwall.com>
Acked-by: Vasily Kulikov <segoon@openwall.com>
Message-Id: <1429540256-4906-1-git-send-email-yegorslists@googlemail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9600
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Diffstat (limited to 'contrib')
-rw-r--r-- | contrib/keychain-mcd/cert_data.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/contrib/keychain-mcd/cert_data.c b/contrib/keychain-mcd/cert_data.c index f2b33ed..a04bf79 100644 --- a/contrib/keychain-mcd/cert_data.c +++ b/contrib/keychain-mcd/cert_data.c @@ -146,6 +146,7 @@ CFArrayRef GetFieldsFromCertificate(SecCertificateRef certificate, CFTypeRef oid printErrorMsg("GetFieldsFromCertificate: SecCertificateCopyValues", error); CFRelease(keySelection); CFRelease(fields); + destroyCertName(pCertName); return NULL; } CFDictionaryRef vals = CFDictionaryGetValue(dict, oid); |